Check earlier for blocks with duplicate transactions. Fixes #1167

phelixnmc · Apr 30, 2012 · be8651d · be8651d
1 parent ec4997d
commit be8651d
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/src/main.cpp b/src/main.cpp
@@ -1652,6 +1652,16 @@ bool CBlock::CheckBlock() const
         if (!tx.CheckTransaction())
             return DoS(tx.nDoS, error("CheckBlock() : CheckTransaction failed"));
 
+    // Check for duplicate txids. This is caught by ConnectInputs(),
+    // but catching it earlier avoids a potential DoS attack:
+    set<uint256> uniqueTx;
+    BOOST_FOREACH(const CTransaction& tx, vtx)
+    {
+        uniqueTx.insert(tx.GetHash());
+    }
+    if (uniqueTx.size() != vtx.size())
+        return DoS(100, error("CheckBlock() : duplicate transaction"));
+
     unsigned int nSigOps = 0;
     BOOST_FOREACH(const CTransaction& tx, vtx)
     {