Added ability to use raw envrionment variables maps in deployment #651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, Internally we use external secret sources,
This PR adds the Ability for the environment variables to reference k8s objects that are per-defined under the pganalyze target namespace by cluster operators.
This solves an issue where a secret that does not conform to either existing methods:
extraEnv
: simplekey: value
stringsconfigMap
orsecret
: injection by usingenvFrom
restricts the data fields conform to target environment variable namesBy allowing helm operator to specify raw elements of the
env
spec of a container, it allows for additional options that are not currently covered.I do not know how you do versioning for same appVersion patching of the chart-side only changes,
I see that most chart releases correspond to app releases, I ran
helm-docs
which is the only section in CONTRIBUTING.md that seems relevant for this type of PREdits: typo, versioning note