Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to use raw envrionment variables maps in deployment #651

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

asaf400
Copy link

@asaf400 asaf400 commented Dec 5, 2024

Hello, Internally we use external secret sources,
This PR adds the Ability for the environment variables to reference k8s objects that are per-defined under the pganalyze target namespace by cluster operators.

This solves an issue where a secret that does not conform to either existing methods:

  • extraEnv: simple key: value strings
  • configMap or secret: injection by using envFrom restricts the data fields conform to target environment variable names

By allowing helm operator to specify raw elements of the env spec of a container, it allows for additional options that are not currently covered.

I do not know how you do versioning for same appVersion patching of the chart-side only changes,
I see that most chart releases correspond to app releases, I ran helm-docs which is the only section in CONTRIBUTING.md that seems relevant for this type of PR

Edits: typo, versioning note

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant