Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: only trigger actions for code analysis workflows after testing changes #662

Merged
merged 8 commits into from
Mar 14, 2024

Conversation

juarezr
Copy link
Member

@juarezr juarezr commented Mar 14, 2024

This PR has the objective of avoiding double triggering of workflows

Changes

  1. only trigger actions for code analysis workflows after testing changes
  2. allow manual triggering of code analysis workflows

Checklist

Use this checklist to ensure the quality of pull requests that include new code and/or make changes to existing code.

  • Source Code guidelines:
    • Includes unit tests
    • New functions have docstrings with examples that can be run with doctest
    • New functions are included in API docs
    • Docstrings include notes for any changes to API or behavior
    • All changes are documented in docs/changes.rst
  • Versioning and history tracking guidelines:
    • Using atomic commits whenever possible
    • Commits are reversible whenever possible
    • There are no incomplete changes in the pull request
    • There is no accidental garbage added to the source code
  • Testing guidelines:
    • Tested locally using tox / pytest
    • Rebased to the master branch and tested before sending the PR
    • Automated testing passes (see CI)
    • Unit test coverage has not decreased (see Coveralls)
  • [
  • State of these changes is:
    • Just a proof of concept
    • Work in progress / Further changes needed
    • Ready to review
    • Ready to merge

@coveralls
Copy link

coveralls commented Mar 14, 2024

Pull Request Test Coverage Report for Build 8287898034

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.072%

Totals Coverage Status
Change from base Build 8286826955: 0.0%
Covered Lines: 13352
Relevant Lines: 14661

💛 - Coveralls

@juarezr juarezr added Maintainability Issues for code modernization, improve development, testing Build CI CD Issues affecting github pypi readthedocs coveralls conda-forge labels Mar 14, 2024
@juarezr juarezr merged commit e7ee54c into petl-developers:master Mar 14, 2024
24 checks passed
@juarezr juarezr deleted the ci/upgrade-workflows-v2 branch March 14, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build CI CD Issues affecting github pypi readthedocs coveralls conda-forge Maintainability Issues for code modernization, improve development, testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants