Upgrade to golangci-lint v0.58.2 #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterstace
commented
May 19, 2024
| @@ -153,7 +153,7 @@ func (c *GeoJSONFeatureCollection) UnmarshalJSON(p []byte) error { | |||
| Type string `json:"type"` | |||
| Features []GeoJSONFeature `json:"features"` | |||
| } | |||
| if err := json.Unmarshal(p, &topLevel); err != nil { //nolint:musttag | |||
There was a problem hiding this comment.
nolint:musttag was to work around a bug, which was fixed in go-simpler/musttag#93.
| @@ -24,7 +24,7 @@ func (ng *NullGeometry) Scan(value interface{}) error { | |||
| // Value implements the database/sql/driver.Valuer interface. | |||
| func (ng NullGeometry) Value() (driver.Value, error) { | |||
| if !ng.Valid { | |||
| return nil, nil | |||
| return nil, nil //nolint:nilnil | |||
There was a problem hiding this comment.
return nil, nil is being detected as suspicious (usually this would be an error). It's not here, because the database/sql/driver.Valuer interface expects nil values (it interprets them as NULL).
albertteoh
approved these changes
May 21, 2024
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per title.
Check List
Have you:
Added unit tests? N/A
Add cmprefimpl tests? (if appropriate?) N/A
Updated release notes? (if appropriate?) Yes.
Related Issue