Manually implement PartialEq and Hash for BinaryExpr
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
merged commit 5e9257c
into
peter-toth:physicalexpr-eq-partialeq-hash
24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets apache#13005
Instead of adding a new parameter to
BinaryExprhere is a proposal to add a manual derivation ofPartialEqandHashWhile this will result in more code (until the rust bug is fixed) I think it would overall make the code easier to understand (as the
PhysicalExprstructs will avoid having a genericIf you agree @peter-toth I can make a PR to your branch to change the other instances