Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transactions/trade: Add SignedTradeOffer Closes #98 #130

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Ruben-Kruepper
Copy link
Contributor

No description provided.

@Ruben-Kruepper Ruben-Kruepper self-assigned this Dec 6, 2021
@Ruben-Kruepper Ruben-Kruepper linked an issue Dec 6, 2021 that may be closed by this pull request
@sebastianst
Copy link
Contributor

Like mentioned in the original issue, the idea was to ultimately improve the type safety in the backend server. For the trading API, trade offers are saved into a mapping of TradeOffers. Then when a trade offer is executed, it it currently asserted that the offer has a sig. Please check if this can be improved, so that incoming trade offers are checked for non-nil sigs and then saved into a mapping of SignedTradeOffers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create type SignedTradeOffer and let TradeOffer.sign return it
2 participants