Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for verification of signatures using non-SHA1 algorithm #117

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

yoh1496
Copy link
Contributor

@yoh1496 yoh1496 commented Nov 22, 2022

Old implementation match algorithm only to DSA_SHA1 and RSA_SHA1.

This PR make it available to verify signature which is not being signed with SHA1 hash algorithm by match to lists containing multiple hash algorithm.

@yoh1496 yoh1496 requested a review from shimono November 22, 2022 08:43
@shimono shimono changed the title Make it available to verify signature with not using SHA1 algorithm Support for verification of signatures using non-SHA1 algorithm Nov 30, 2022
@shimono shimono merged commit dceb447 into personium:develop Nov 30, 2022
@yoh1496
Copy link
Contributor Author

yoh1496 commented Nov 30, 2022

To add feature to verify tokens signed with newer hash algorithm on older version, please cherry-pick this commit onto older personium-lib-common and use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants