Merge pull request #945 from permaweb/jfrain99/remove-random-data-bits

fix(connect): stop adding random bits to empty data in aoconnect
permaweb · Aug 19, 2024 · 186414d · 186414d
2 parents da46b9e + 4cc47d6
commit 186414d
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/connect/src/lib/message/upload-message.js b/connect/src/lib/message/upload-message.js
@@ -68,9 +68,9 @@ function buildDataWith ({ logger }) {
          */
         () => Resolved(ctx),
         /**
-         * Just generate a random value for data
+         * No data is provided, so replace with one space
          */
-        () => Resolved(Math.random().toString().slice(-4))
+        () => Resolved(' ')
           .map(assoc('data', __, ctx))
           /**
            * Since we generate the data value, we know it's Content-Type,

diff --git a/connect/src/lib/monitor/upload-monitor.js b/connect/src/lib/monitor/upload-monitor.js
@@ -38,9 +38,9 @@ export function uploadMonitorWith (env) {
           /**
            * No tags or data can be provided right now,
            *
-           * so just randomize data and set tags to an empty array
+           * so just set data to single space and set tags to an empty array
            */
-          data: Math.random().toString().slice(-4),
+          data: ' ',
           tags: []
         })
       ))

diff --git a/connect/src/lib/spawn/upload-process.js b/connect/src/lib/spawn/upload-process.js
@@ -59,9 +59,9 @@ function buildDataWith ({ logger }) {
          */
         () => Resolved(ctx),
         /**
-         * Just generate a random value for data
+         * No data is provided, so replace with one space
          */
-        () => Resolved(Math.random().toString().slice(-4))
+        () => Resolved(' ')
           .map(assoc('data', __, ctx))
           /**
            * Since we generate the data value, we know it's Content-Type,

diff --git a/connect/src/lib/unmonitor/upload-unmonitor.js b/connect/src/lib/unmonitor/upload-unmonitor.js
@@ -38,9 +38,9 @@ export function uploadUnmonitorWith (env) {
           /**
            * No tags or data can be provided right now,
            *
-           * so just randomize data and set tags to an empty array
+           * so just set data to single space and set tags to an empty array
            */
-          data: Math.random().toString().slice(-4),
+          data: ' ',
           tags: []
         })
       ))

diff --git a/servers/mu/src/domain/clients/signer.js b/servers/mu/src/domain/clients/signer.js
@@ -3,7 +3,7 @@ const { createData, ArweaveSigner } = pkg
 
 function buildAndSignWith ({ MU_WALLET }) {
   return async ({ processId, data, tags, anchor }) => {
-    data = data || Math.random().toString().slice(-4)
+    data = data || ' ' // If no data, send a single space
     const signer = new ArweaveSigner(MU_WALLET)
 
     const interactionDataItem = createData(data, signer, { target: processId, anchor, tags })