fix(ur): return 404 if process id cannot be extracted from request #790

permaweb · Jun 12, 2024 · 04b49bf · 04b49bf
1 parent 7d3833b
commit 04b49bf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/servers/ur/src/proxy.js b/servers/ur/src/proxy.js
@@ -66,6 +66,8 @@ export function proxyWith ({ aoUnit, hosts, subrouterUrl, surUrl, owners, proces
       always(async (req, res) => {
         const processId = await processIdFromRequest(req)
 
+        if (!processId) return res.status(404).send({ error: 'Process id not found on request' })
+
         async function revProxy ({ failoverAttempt, err }) {
           /**
            * In cases where we have to consume the request stream before proxying

diff --git a/servers/ur/src/redirect.js b/servers/ur/src/redirect.js
@@ -18,8 +18,13 @@ export function redirectWith ({ aoUnit, hosts, subrouterUrl, surUrl, owners, pro
    * by the injected business logic.
    */
   const redirectHandler = ({ processIdFromRequest }) => {
+    // TODO: should we compose an error handler, similar to proxy.js?
+    // for now, just keeping as is.
     return async (req, res) => {
       const processId = await processIdFromRequest(req)
+
+      if (!processId) return res.status(404).send({ error: 'Process id not found on request' })
+
       const host = await determineHost({ processId })
 
       _logger('Redirecting process %s to host %s', processId, host)