Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also load configuration from setup.cfg #57

Merged
merged 3 commits into from
Dec 28, 2014
Merged

Conversation

t-8ch
Copy link
Contributor

@t-8ch t-8ch commented Sep 22, 2014

Fixes #49

Fixes peritus#49

This patch is optimized for maximum compatability.
@peritus
Copy link
Owner

peritus commented Oct 22, 2014

Nice patch!

Note to self: Needs documentation (1 sentence in README should do).

@@ -73,7 +78,7 @@ def _mock_calls_to_string(called_mock):
optional arguments:
-h, --help show this help message and exit
--config-file FILE Config file to read most of the variables from
(default: .bumpversion.cfg)
(default: None)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should still say .bumpversion.cfg here, just for people who use --help to find out the default.

@t-8ch
Copy link
Contributor Author

t-8ch commented Oct 24, 2014

@peritus I pushed a new patch. It is a bit uglier as before but behaves as
following:

  • If --config-file is not passed it tries to use .bumpversion.cfg or
    setup.cfg and falls back to the builtin defaults.
  • If the configfile is explicitly specified and can not be read we error out.
  • It also errors out if the user specified one of the default config files
    explicitly and they are broken. (The implementation of this is, what makes
    the thing a bit ugly)

@ionelmc
Copy link

ionelmc commented Dec 21, 2014

@peritus Any chance you gonna merge/release this soon?

@peritus peritus merged commit 117842b into peritus:master Dec 28, 2014
peritus added a commit that referenced this pull request Dec 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load configuration from setup.cfg
3 participants