Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -kanal as seperable street suffix #85

Merged
merged 2 commits into from
Mar 19, 2020
Merged

add -kanal as seperable street suffix #85

merged 2 commits into from
Mar 19, 2020

Conversation

missinglink
Copy link
Member

highlighted in pelias/pelias#854 the parser was not familiar with Am Nordkanal being a valid street name.
I've added -kanal to the list of German suffixes commonly found in street names.

closes pelias/pelias#854

@msschl
Copy link

msschl commented Mar 19, 2020

-allee e.g. Königsallee in Düsseldorf
-platz e.g. Rathausplatz
-weg e.g. Plutoweg
-strasse e.g. Dorfstrasse

Copy link
Member

@Joxit Joxit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Joxit
Copy link
Member

Joxit commented Mar 19, 2020

You can add tests for Königsallee and Plutoweg.
They are already working but not in our tests.

@missinglink
Copy link
Member Author

@msschl the other cases you provided already seem to work fine, I added some test cases anyway in 662ed6f

@missinglink missinglink merged commit cc82ac7 into master Mar 19, 2020
@missinglink missinglink deleted the de_kanal branch March 19, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different/Not reliable results on autocomplete and search endpoints
3 participants