Supports for single quotes in personal title #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In the French grammar, there are 8 article
le
,la
,les
,un
,une
,du
,de
,la
. When an article likele
orde
is used with a noun which starts with a vowel, the article's vowel is replaced by a simple quote. For example, we don't writeLe Amiral
butL'Amiral
.So what ?
This PR fixes these edge cases which are common.
I think this should be spread in some other classifiers (such as
GivenNameClassifier
)