-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append unclassified tokens to the street #28
base: master
Are you sure you want to change the base?
Conversation
68ca511
to
47b5a61
Compare
47b5a61
to
41535f0
Compare
One thing I worry about with this is how it will affect Pelias queries generated from autocomplete input.... |
I'm not sure about rewriting the span body, is this really required? The combination of these tokens should already be present in the 'phrases' for that section. It should be possible to find the phrase you are looking for and then classify it directly to avoid editing any of the existing spans. |
Hum, you're totally right, the last token shouldn't be appended.
I wanted to have your opinion on this PR. There are also something that bothers me in what I did.... |
…the street This will be used only when StreetPrefixClassification is used. Remove Paris from regions and add cité in street_types. Paris is always used as a locality
41535f0
to
f7c155f
Compare
Now I replace the solution with the correct phrase
I've updated this PR.
|
I created a solver that can fill the blanks (only for StreetPrefixClassification).
We have some very long streets names, and this is not simple to safely match all street names.
I thought that the best way to do this is to append unclassified tokens to the street (when the token is at the end of the street).
Maybe it can also be used for venues.
Paris is always used as a locality, so I removed it from regions.
Add cité in street_types.