Skip to content

Commit

Permalink
Use only console.log in terminal outpt
Browse files Browse the repository at this point in the history
`console.error` does not always have the same buffering settings as
`console.log` and so printing to both does not always cause output to be
shown in the intended order. `console.error` should only be used for
real errors that happen elsewhere.
  • Loading branch information
orangejulius committed Apr 4, 2016
1 parent 6e9cde6 commit 837d9a9
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions output_generators/terminal.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,17 @@ function prettyPrintResult( result ){

case 'fail':
var color = (result.progress === 'regression') ? 'red' : 'yellow';
console.error(
console.log(
util.format( ' ✘ %s[%s] "%s": %s', status, id, testDescription, result.msg )[ color ]
);
break;

case 'placeholder':
console.error( util.format( ' ! [%s] "%s": %s', id, testDescription, result.msg ).cyan );
console.log( util.format( ' ! [%s] "%s": %s', id, testDescription, result.msg ).cyan );
break;

default:
console.error( util.format( 'Result type `%s` not recognized.', result.result ) );
console.log( util.format( 'Result type `%s` not recognized.', result.result ) );
process.exit( 1 );
break;
}
Expand All @@ -67,8 +67,8 @@ function prettyPrintSuiteResults( suiteResults, config, testSuites ){

console.log( '\nAggregate test results'.blue );
console.log( 'Pass: ' + suiteResults.stats.pass.toString().green );
console.error( 'Fail: ' + suiteResults.stats.fail.toString().yellow );
console.error( 'Placeholders: ' + suiteResults.stats.placeholder.toString().cyan );
console.log( 'Fail: ' + suiteResults.stats.fail.toString().yellow );
console.log( 'Placeholders: ' + suiteResults.stats.placeholder.toString().cyan );

var numRegressions = suiteResults.stats.regression;
var regressionsColor = ( numRegressions > 0 ) ? 'red' : 'yellow';
Expand All @@ -81,7 +81,7 @@ function prettyPrintSuiteResults( suiteResults, config, testSuites ){

console.log( '' );
if( numRegressions > 0 ){
console.error( 'FATAL ERROR: %s regression(s) detected.'.red.inverse, numRegressions );
console.log( 'FATAL ERROR: %s regression(s) detected.'.red.inverse, numRegressions );
return 1;
}
else {
Expand Down

0 comments on commit 837d9a9

Please sign in to comment.