Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getBroadcasts function #3350

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alechkos
Copy link
Collaborator

@alechkos alechkos commented Oct 24, 2024

PR Details

The PR fixes an issue where the Client.getBroadcasts function throws an error:

Error: Evaluation failed: TypeError: message.serialize is not a function

Description

After deserializing a Status object in window.WWebJS.getStatusModel, the object was mistakenly passed to window.WWebJS.getMessageModel for further deserialization. This caused an error because the object had already been deserialized.

How Has This Been Tested

// client initialization...

client.once('ready', async () => {
    console.log(await client.getBroadcasts())
});

Tested on both regular and business WhatsApp accounts.

You can try the fix by running one of the following commands:

  • NPM
npm install github:alechkos/whatsapp-web.js#fix-broadcasts
  • YARN
yarn add github:alechkos/whatsapp-web.js#fix-broadcasts

Types of changes

  • Dependency change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (index.d.ts).

@themazim
Copy link
Contributor

fixes the issues 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants