Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete function for messages #3301

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

alechkos
Copy link
Collaborator

@alechkos alechkos commented Sep 28, 2024

PR Details

Fix for the Message.delete function.

Description

The PR fixes an issue where the delete function does not delete messages.

Also was added a possibility to pass a second boolean value into the function for clearing media in the device (true by default).

Related Issue

closes #3245

How Has This Been Tested

// client initialization...

client.on('message', async (message) => {
    const sender = '[email protected]';
    if (message?.author === sender || message?.from === sender) {
        // delete for everyone: true, clear media in device: true (by default)
        await message.delete(true);
        // delete for everyone: true, clear media in device: false
        await message.delete(true, false);
        // delete for everyone: false, clear media in device: true (by default)
        await message.delete(false);
        // delete for everyone: false, clear media in device: false
        await message.delete(false, false);
    }
});

Everything works as expected.

You can try the fix by running one of the following commands:

  • NPM
npm install github:alechkos/whatsapp-web.js#fix-delete-msg
  • YARN
yarn add github:alechkos/whatsapp-web.js#fix-delete-msg

Types of changes

  • Dependency change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (index.d.ts).

@alechkos alechkos requested a review from tuyuribr September 30, 2024 17:06
@alechkos alechkos removed the request for review from purpshell October 1, 2024 14:15
@hveiras
Copy link

hveiras commented Dec 9, 2024

Tested in my fork, seems to be working fine so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

message.delete() is not working
3 participants