Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added validations on keywords & identifiers for search catalog_items API #62

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

amoludage
Copy link
Contributor

Current Behaviour -

  • For SearchCatalogItems API, if we send keywords and identifiers both the values then we calling SPAPI and getting error from that API that is Invalid combination of 'identifiers' and 'keywords' provided. This is because the API support either of these values and not both.
  • Also, if we don't send any of these two values to the API then we are getting error from SPAPI that is Missing required 'identifiers' or 'keywords'.

Problem Statement -

  • This gem should avoid such API calls to SPAPI if the expected parameters are missing.

Proposed Solution -

  • We are adding validations on keywords and identifiers in this gem and avoid SPAPI API call and return error from the gem only.

@amoludage amoludage force-pushed the fix/api-validation-improvements/catalog-items branch from cfe6ad2 to b4c1aac Compare April 2, 2024 07:41
@amoludage amoludage merged commit 4831625 into master Apr 3, 2024
9 checks passed
@amoludage amoludage deleted the fix/api-validation-improvements/catalog-items branch April 3, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants