fix(Chatbot): Handle zoom appropriately #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://chatbot-pr-chatbot-338.surge.sh A11y report: https://chatbot-pr-chatbot-338-a11y.surge.sh |
rebeccaalpert
force-pushed
the
zooming
branch
from
28da006 to
2e0e521
Compare
This was
linked to
issues
Nov 25, 2024
Allows entire chatbot to scroll like a normal website when zoom is high. Hides jump links since they won't work. Also adds responsive styles to chatbot on docked and overlay.
rebeccaalpert
force-pushed
the
zooming
branch
from
2e0e521 to
5a7f1c3
Compare
nicolethoen
reviewed
Dec 3, 2024
| // 30rem is the width of the docked chatbot | ||
| // if the screen is smaller, we want to be 100% | ||
| @media screen and (max-width: 30rem) { | ||
| padding-right: 0px; |
There was a problem hiding this comment.
nit: rather than padding right, I think you should use padding-inline-start to maintain right to left language support.
nicolethoen
approved these changes
Dec 3, 2024
|
🎉 This PR is included in version 2.1.0-prerelease.23 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows entire chatbot to scroll like a normal website when zoom is high. Hides jump links since they won't work. Also adds responsive styles to chatbot on docked and overlay.
One example is here: https://chatbot-pr-chatbot-338.surge.sh/patternfly-ai/chatbot/overview/demo/basic-chatbot/; go to 150% or 200%.