fix(MessageBar): Swap out textarea #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccaalpert
force-pushed
the
contenteditable
branch
2 times, most recently
from
66c6290 to
338047b
Compare
rebeccaalpert
force-pushed
the
contenteditable
branch
from
338047b to
f3b2944
Compare
rebeccaalpert
force-pushed
the
contenteditable
branch
from
f3b2944 to
4396bdd
Compare
nicolethoen
requested changes
Nov 18, 2024
There was a problem hiding this comment.
I don't love that after I've started typing a message, then fire a blur event, the draft i've started typing gets erased.
I'm also noticing that if I paste formatted text into the text area, it get's lost now when it didn't used to.
The following snippet produces the first screenshot in the currently implementation, and the second screenshot in your PR
Let's see
Hi
currently on patternfly.org
now in your PR:
rebeccaalpert
force-pushed
the
contenteditable
branch
3 times, most recently
from
a9e7f37 to
8260bcc
Compare
rebeccaalpert
force-pushed
the
contenteditable
branch
from
8260bcc to
5b75285
Compare
nicolethoen
approved these changes
Nov 19, 2024
|
🎉 This PR is included in version 2.1.0-prerelease.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try contentedible div instead of textarea (was having problems on small screens in Firefox/Safari).