-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update documentation side bar nav organization #310
docs: update documentation side bar nav organization #310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we want to make the modals, attachment error, and attachment dropzone part of the UI section. Same with the attachment label - we use the attachment label as part of messages, but also in the footer. We don't have a demo that explicitly demonstrates this, but I can add one in a separate PR after this merges.
We're also going to have to fix all the links - pretty much every link is broken now. I'd be happy to merge this and then fix them on my side if that's helpful.
Ah i didn't think to check the links. I can definitely do that as part of this. |
d720326
to
1be707a
Compare
@rebeccaalpert updated the links 👍🏻 and rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing the links. It looks like a few more broke during the rebase - I added suggestions for those.
packages/module/patternfly-docs/content/extensions/virtual-assistant/examples/demos/Chatbot.md
Outdated
Show resolved
Hide resolved
packages/module/patternfly-docs/content/extensions/virtual-assistant/examples/UI/UI.md
Outdated
Show resolved
Hide resolved
…istant/examples/demos/Chatbot.md Co-authored-by: Rebecca Alpert <[email protected]>
…istant/examples/UI/UI.md Co-authored-by: Rebecca Alpert <[email protected]>
c2dc8c7
to
39bf068
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me! Thanks for fixing those links.
🎉 This PR is included in version 2.1.0-prerelease.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
* docs: update documentation side bar nav organization * rebase and regenerate screenshots for new example * Update packages/module/patternfly-docs/content/extensions/virtual-assistant/examples/demos/Chatbot.md Co-authored-by: Rebecca Alpert <[email protected]> * Update packages/module/patternfly-docs/content/extensions/virtual-assistant/examples/UI/UI.md Co-authored-by: Rebecca Alpert <[email protected]> --------- Co-authored-by: Rebecca Alpert <[email protected]>
Closes #300
Closes #282