fix(Message): Truncate very long names #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edonehoo
reviewed
Nov 6, 2024
.../patternfly-docs/content/extensions/virtual-assistant/examples/ChatbotMessage/BotMessage.tsx
Outdated
Show resolved
Hide resolved
.../patternfly-docs/content/extensions/virtual-assistant/examples/ChatbotMessage/BotMessage.tsx
Outdated
Show resolved
Hide resolved
.../patternfly-docs/content/extensions/virtual-assistant/examples/ChatbotMessage/BotMessage.tsx
Outdated
Show resolved
Hide resolved
edonehoo
reviewed
Nov 7, 2024
| @@ -50,17 +50,25 @@ export default MessageLoading; | |||
|
|
|||
| return ( | |||
| <> | |||
| <Message name="Bot" role="bot" avatar={patternflyAvatar} content={`Text-based message from a bot named "Bot`} /> | |||
There was a problem hiding this comment.
Suggested change
| <Message name="Bot" role="bot" avatar={patternflyAvatar} content={`Text-based message from a bot named "Bot`} /> | |
| <Message name="Bot" role="bot" avatar={patternflyAvatar} content={`Text-based message from a bot named "Bot"`} /> |
There was a problem hiding this comment.
Thank you eagle-eyed Erin!
kaylachumley
approved these changes
Nov 8, 2024
rebeccaalpert
force-pushed
the
truncation
branch
from
ac484b6 to
295a759
Compare
nicolethoen
approved these changes
Nov 11, 2024
rebeccaalpert
force-pushed
the
truncation
branch
from
295a759 to
b3a0b3d
Compare
|
🎉 This PR is included in version 2.1.0-prerelease.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our API has name as optional - I'm letting it render as optional and then also adding truncation if it gets really long. We prioritize the timestamp at full width over the name right now - let me know if we want to prioritize the name over the timestamp instead.