fix(MessageBox): Announce new messages #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 12, 2024
rebeccaalpert
force-pushed
the
a11y-217
branch
4 times, most recently
from
d73542c to
d81a5ff
Compare
Messages should be announced to assistive devices. I added a prop to MessageBox to allow for this and updated our two demos with message sending so they make announcements. I also documented this in the Chatbot container docs. I checked this worked with VoiceOver, but I can't speak to any other tools.
rebeccaalpert
force-pushed
the
a11y-217
branch
from
d81a5ff to
f12aca1
Compare
nicolethoen
reviewed
Oct 14, 2024
| @@ -72,6 +78,9 @@ const MessageBox: React.FunctionComponent<MessageBoxProps> = ({ children, classN | |||
| <JumpButton position="top" isHidden={isOverflowing && atTop} onClick={scrollToTop} /> | |||
| <div className={`pf-chatbot__messagebox ${className ?? ''}`} ref={messageBoxRef}> | |||
| {children} | |||
| <div className="pf-chatbot__messagebox-announcement" aria-live="polite"> | |||
There was a problem hiding this comment.
If this always exists on the page, I wonder if it could be set programatically (if an announcement is not passed by default. Like could we provide an out of the box default that reads out the new announcement?)
I think that could be a resonable follow up for the future.
nicolethoen
approved these changes
Oct 14, 2024
|
🎉 This PR is included in version 2.0.0-alpha.54 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages should be announced to assistive devices. I added a prop to MessageBox to allow for this and updated our two demos with message sending so they make announcements. I also documented this in the Chatbot container docs. I checked this worked with VoiceOver, but I can't speak to any other tools.
Taking this opportunity to also switch our scrolling method and add better ids.