Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server to support asset change detection #1144

Merged
merged 4 commits into from
Apr 24, 2020
Merged

Update server to support asset change detection #1144

merged 4 commits into from
Apr 24, 2020

Conversation

JosefBredereck
Copy link
Contributor

@JosefBredereck JosefBredereck commented Apr 12, 2020

Closes #

#1064 #1130 #957

Needs to be tested on Mac before close #

#1114

Summary of changes:

Fix listed bugs / feature requests and also did a refactoring on the server to match eslint config.

@bmuenzenmeyer bmuenzenmeyer self-assigned this Apr 14, 2020
@bmuenzenmeyer bmuenzenmeyer self-requested a review April 14, 2020 12:19
@bmuenzenmeyer
Copy link
Member

I tested this the following way:

yarn preview:hbs
cd packages/development-edition-engine-handlebars
yarn pl:serve

make change to source/css/pattern-scaffolding.css

changes are not reflected in the running app

@JosefBredereck
Copy link
Contributor Author

I just reproduced your test with npm run pl:serve and yarn pl:serve on windows. For me it is working. The problem maybe is, that this isn't written in the console, because chokidar.watch() doesn't say which files changed at that point. You can turn this on when you add logLevel > 0 to your patternlab.config.serverOptions. (That behavior was implemented before)

If you change something in source/css/pattern-scaffolding.css you will notice the browser reloads. To be sure with this test you could try to add something like this.

body {
   background: red;
}

@bmuenzenmeyer
Copy link
Member

@JosefBredereck i apologize - i tried pulling this fork locally a new way and as it turns out, I had NONE of your changes 😊

This now is working for me too - tested on Mac and Windows

@bmuenzenmeyer bmuenzenmeyer merged commit 5793d7f into pattern-lab:dev Apr 24, 2020
@JosefBredereck
Copy link
Contributor Author

@bmuenzenmeyer do we close the tickets accordingly?

@bmuenzenmeyer
Copy link
Member

they should auto close when released - if you dont mind waiting for that

antonia-rose pushed a commit to quelltexterin/nemo-uikit-workshop that referenced this pull request Apr 12, 2023
…r-asset-change

Update server to support asset change detection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants