Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIKit excluded tag support #844

Closed
bmuenzenmeyer opened this issue Apr 27, 2018 · 2 comments · Fixed by #1140
Closed

UIKit excluded tag support #844

bmuenzenmeyer opened this issue Apr 27, 2018 · 2 comments · Fixed by #1140

Comments

@bmuenzenmeyer
Copy link
Member

As part of #811 and #840 we hoped to deliver excludedTags support within a UIKit. This is certainly possible, but I wanted to release early with state support first.

If someone wants to take on this work it would look similar to 87c9d0d

  • add this filter to uikitExcludePattern
  • add tests
@stale
Copy link

stale bot commented Jun 26, 2018

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

@bmuenzenmeyer bmuenzenmeyer added the pinned 📌 Don't let stalebot clean this up label Jun 29, 2018
@Hydraner
Copy link
Contributor

Hey @bmuenzenmeyer , thanks for the great work on PL3. I am currently using tons of the "new" stuff and fought already a couple of issues and created PR's.

I'm not so much into node development so I hope to get some feedback to make things as good as possible to get some things commited.

I also didn't manage to get the test suite up and running, so all tests I wrote so far have been produced in blind flight mode. It would be great if you could give me some advice on this.

This issue should also fix #1079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants