Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twig: Logo links rendered as "NaN" #1407

Closed
mfranzke opened this issue Jan 3, 2022 · 0 comments · Fixed by #1434
Closed

Twig: Logo links rendered as "NaN" #1407

mfranzke opened this issue Jan 3, 2022 · 0 comments · Fixed by #1434
Labels
twig renderer Issues and updates related to the PHP-based Twig rendering engine

Comments

@mfranzke
Copy link
Contributor

mfranzke commented Jan 3, 2022 •
edited
Loading

I am using Pattern Lab Node v5.15.7 on Mac, with Node v12.13.1, using a Vanilla Edition and Twig Engine.

Expected Behavior

All links render correctly.

Actual Behavior

The links (href-attribute) for logo elements (most likely out of /packages/starterkit-twig-demo/dist/_patterns/atoms/images/logo.twig / {{ link.pages-homepage }}) are currently being rendered as "NaN"

Steps to Reproduce

Start a local instance e.g. with yarn run setup && yarn run preview:hbs && cd packages/development-edition-engine-twig/ && yarn dev from root and open http://localhost:3000/?p=atoms-logo

image
@mfranzke mfranzke added the twig renderer Issues and updates related to the PHP-based Twig rendering engine label Jan 3, 2022
hadl added a commit to hadl/patternlab-node that referenced this issue Apr 10, 2022
@hadl
fix: twig logo is rendered as "NaN"
0fa0cf8 
Closes: pattern-lab#1407
@hadl hadl mentioned this issue Apr 10, 2022
Merged
JosefBredereck pushed a commit that referenced this issue Sep 21, 2022
@hadl
fix: twig logo is rendered as "NaN" (#1434)
ab6b133 
Closes: #1407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
twig renderer Issues and updates related to the PHP-based Twig rendering engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: twig logo is rendered as "NaN" hadl/patternlab-node
1 participant
@mfranzke