Skip to content
This repository has been archived by the owner on Feb 7, 2023. It is now read-only.

Fix to grunt config and documentation #22

Merged
merged 2 commits into from
Feb 23, 2017
Merged

Conversation

u982744
Copy link
Contributor

@u982744 u982744 commented Nov 9, 2016

Addresses #

Summary of changes:

  • Correct grunt config as it was not copying nested directories and files

bmuenzenmeyer and others added 2 commits August 16, 2016 01:25
- Correct grunt config as it was not copying nested directories and files
@tburny tburny changed the base branch from master to dev February 23, 2017 14:20
@tburny tburny self-requested a review February 23, 2017 14:32
@tburny tburny added the bug label Feb 23, 2017
@tburny tburny self-assigned this Feb 23, 2017
@tburny
Copy link
Contributor

tburny commented Feb 23, 2017

I reviewed and tested the changes, as I tripped into the problems myself. These look very good, thanks for your efforts!

Explanation of the documentation change:
grunt.registerTask('default', ['patternlab', 'copy:main']); would also copy the CSS (same as watch and serve) and then call patternlab, triggering pl.build (as arguments.length == 0) while grunt patternlab:build does not execute the copy:main task and thus no resources are copied.

@tburny tburny merged commit 5ad5bf7 into pattern-lab:dev Feb 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants