Add support for repository_dispatch event #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalgn
reviewed
Jul 26, 2020
lib/api.js
Outdated
| @@ -299,4 +301,43 @@ async function handleIssueComment(context, eventName, event) { | |||
| } | |||
| } | |||
|
|
|||
| async function handleRepositoryDispatch(context) { | |||
There was a problem hiding this comment.
This looks like it's just copied from handleScheduleTrigger. Instead, there should be a common method, e.g. handleScheduleTriggerOrRepositoryDispatch
There was a problem hiding this comment.
That makes sense, I'll do it that way. The logic behind copying/duplicating was that while the logic for ScheduleTrigger and RepositoryDispatch are the same right now, it's likely that in the future a feature/enhancement will apply to one and not the other
|
Thanks for the PR, it's merged now! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for repository_dispatch as an event type. Using the same logic as the
labeledevent since the workflow should be similar.