Fix missing MuteToAll behavior

FaderSyncPlugin/OBS/GoXlrChannelSyncFilter.cs

@@ -1,31 +1,21 @@
+using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 using System.Text;
 using System.Text.Json.Nodes;
 using FaderSync.GoXLR;
-using GoXLRUtilityClient;
 using ObsInterop;
 
 namespace FaderSync.OBS;
 
 // ReSharper disable once ClassNeverInstantiated.Global
 public class GoXlrChannelSyncFilter
 {
-    private static readonly Logger Log = new Logger(typeof(Plugin));
+    private static readonly Logger Log = new(typeof(Plugin));
 
-    unsafe struct FilterContext
-    {
-        public obs_source* Source;
-        public obs_data* Settings;
-        public bool* IsEnabled;
-
-        public sbyte* DeviceSerial;
-        public sbyte* ChannelName;
-    }
-
     /**
-     * Registers the Filter in OBS. 
+     * Registers the Filter in OBS.
      */
-    public static unsafe void Register(String moduleBaseName)
+    public static unsafe void Register(string moduleBaseName)
     {
         var sourceInfo = new obs_source_info();
         fixed (byte* id = Encoding.UTF8.GetBytes($"{moduleBaseName}/{nameof(GoXlrChannelSyncFilter)}"))
@@ -40,31 +30,33 @@ public static unsafe void Register(String moduleBaseName)
             sourceInfo.update = &Update;
             sourceInfo.get_defaults = &GetDefaults;
             sourceInfo.get_properties = &GetProperties;
-            
+
             ObsSource.obs_register_source_s(&sourceInfo, (nuint)Marshal.SizeOf(sourceInfo));
         }
     }
 
-    [UnmanagedCallersOnly(CallConvs = new[] { typeof(System.Runtime.CompilerServices.CallConvCdecl) })]
+    [UnmanagedCallersOnly(CallConvs = new[] { typeof(CallConvCdecl) })]
     private static unsafe sbyte* GetName(void* data)
     {
         fixed (byte* namePtr = "Sync volume with GoXLR Channel"u8)
+        {
             return (sbyte*)namePtr;
+        }
     }
 
     /**
      * Initialized the Filter for OBS and also creates a context since this is not a class.
      * This function can be seen as some sort of constructor.
      */
-    [UnmanagedCallersOnly(CallConvs = new[] { typeof(System.Runtime.CompilerServices.CallConvCdecl) })]
+    [UnmanagedCallersOnly(CallConvs = new[] { typeof(CallConvCdecl) })]
     private static unsafe void* Create(obs_data* settings, obs_source* source)
     {
         Log.Debug("Filter created!");
-        
+
         var context = ObsBmem.bzalloc<FilterContext>();
         context->Source = source;
         context->Settings = settings;
-        
+
         fixed (byte* sChannelNameId = "CHANNEL_NAME"u8.ToArray(), sDeviceSerialId = "DEVICE_SERIAL"u8.ToArray())
         {
             context->DeviceSerial = ObsData.obs_data_get_string(settings, (sbyte*)sDeviceSerialId);
@@ -73,29 +65,29 @@ public static unsafe void Register(String moduleBaseName)
 
         return context;
     }
-    
-    [UnmanagedCallersOnly(CallConvs = new[] { typeof(System.Runtime.CompilerServices.CallConvCdecl) })]
+
+    [UnmanagedCallersOnly(CallConvs = new[] { typeof(CallConvCdecl) })]
     private static unsafe void Destroy(void* data)
     {
         Log.Debug("Filter destroyed!");
 
         var context = (FilterContext*)data;
         ObsBmem.bfree(context);
     }
-    
+
     /**
      * Gets called every frame.
      * Requests current volume from the GoXLR Utility and translates the volume to the OBS volume scale.
      */
-    [UnmanagedCallersOnly(CallConvs = new[] { typeof(System.Runtime.CompilerServices.CallConvCdecl) })]
+    [UnmanagedCallersOnly(CallConvs = new[] { typeof(CallConvCdecl) })]
     private static unsafe void Tick(void* data, float seconds)
     {
         var utility = UtilitySingleton.GetInstance();
         var context = (FilterContext*)data;
 
         var deviceSerial = Marshal.PtrToStringUTF8((IntPtr)context->DeviceSerial);
         var channelName = Marshal.PtrToStringUTF8((IntPtr)context->ChannelName);
-        
+
         var target = Obs.obs_filter_get_parent(context->Source);
         var systemVolume = utility.Status?["mixers"]?[deviceSerial ?? ""]?["levels"]?["volumes"]?[channelName ?? ""]?
             .GetValue<int>() ?? 0;
@@ -104,65 +96,67 @@ private static unsafe void Tick(void* data, float seconds)
         // doesn't appear to be an exact science, but this should get us close enough to accurate for now.
 
         // So, start simply, how many multiples of 4.85 are we below max (number of dB we need to decrease by)?
-        float utilityBase = (255f - (float)systemVolume) / 4.85f;
+        var utilityBase = (255f - systemVolume) / 4.85f;
 
         // Below 140, the adjustment increases, so we need to accommodate for that here.
-        if (systemVolume < 140) {
+        if (systemVolume < 140)
+        {
             var count = 140 - systemVolume;
             utilityBase += count * 0.115f;
         }
 
         // Now we convert this into a OBS value...
-        float obsVolume = (float)Math.Pow(10, -utilityBase / 20f);
-        
+        var obsVolume = (float)Math.Pow(10, -utilityBase / 20f);
+
         // check if channel is muted
-        bool isMuted = false;
-        JsonObject? faderStatus = (JsonObject) utility.Status?["mixers"]?[deviceSerial ?? ""]?["fader_status"];
+        var isMuted = false;
+        var faderStatus = (JsonObject)utility.Status?["mixers"]?[deviceSerial ?? ""]?["fader_status"];
         if (faderStatus != null)
-        {
             foreach (var faderEntry in faderStatus)
             {
                 if (faderEntry.Value?["channel"]?.GetValue<string>() != channelName) continue;
-            
+
                 isMuted = faderEntry.Value?["mute_state"]?.GetValue<string>() == "MutedToAll" ||
                           (faderEntry.Value?["mute_state"]?.GetValue<string>() == "MutedToX" &&
-                           faderEntry.Value?["mute_type"]?.GetValue<string>() == "ToStream");
+                           (
+                               faderEntry.Value?["mute_type"]?.GetValue<string>() == "ToStream" ||
+                               faderEntry.Value?["mute_type"]?.GetValue<string>() == "All"
+                           ));
                 break;
             }
-        }
-
+
         // Update OBS Volume
-        Obs.obs_source_set_volume(target,  obsVolume);
+        Obs.obs_source_set_volume(target, obsVolume);
         Obs.obs_source_set_muted(target, isMuted ? (byte)1 : (byte)0);
     }
-    
-    [UnmanagedCallersOnly(CallConvs = new[] { typeof(System.Runtime.CompilerServices.CallConvCdecl) })]
+
+    [UnmanagedCallersOnly(CallConvs = new[] { typeof(CallConvCdecl) })]
     private static unsafe void GetDefaults(obs_data* settings)
     {
         // Todo: implement
     }
-    
-    [UnmanagedCallersOnly(CallConvs = new[] { typeof(System.Runtime.CompilerServices.CallConvCdecl) })]
+
+    [UnmanagedCallersOnly(CallConvs = new[] { typeof(CallConvCdecl) })]
     private static unsafe obs_properties* GetProperties(void* data)
     {
         var properties = ObsProperties.obs_properties_create();
 
-        fixed (byte* 
-            tWarnTitle = "Attention"u8.ToArray(),
-            tWarnMessage = "The GoXLR Utility is currently not running."u8.ToArray(),
+        fixed (byte*
+               tWarnTitle = "Attention"u8.ToArray(),
+               tWarnMessage = "The GoXLR Utility is currently not running."u8.ToArray(),
 
-            // add channels
-            sChannelNameId = "CHANNEL_NAME"u8.ToArray(),
-            sChannelNameDescription = "Channel Name"u8.ToArray(),
+               // add channels
+               sChannelNameId = "CHANNEL_NAME"u8.ToArray(),
+               sChannelNameDescription = "Channel Name"u8.ToArray(),
 
-            // device serial input
-            sDeviceSerialId = "DEVICE_SERIAL"u8.ToArray(),
-            sDeviceSerialDescription = "Device Serial"u8.ToArray())
+               // device serial input
+               sDeviceSerialId = "DEVICE_SERIAL"u8.ToArray(),
+               sDeviceSerialDescription = "Device Serial"u8.ToArray())
         {
             // channel name text field
             ObsProperties.obs_properties_add_text(properties, (sbyte*)sChannelNameId, (sbyte*)sChannelNameDescription,
                 obs_text_type.OBS_TEXT_DEFAULT);
-            
+
             // device serial text field
             ObsProperties.obs_properties_add_text(properties, (sbyte*)sDeviceSerialId, (sbyte*)sDeviceSerialDescription,
                 obs_text_type.OBS_TEXT_DEFAULT);
@@ -176,7 +170,7 @@ private static unsafe void GetDefaults(obs_data* settings)
     /**
      * Called when the user changes the settings for the filter
      */
-    [UnmanagedCallersOnly(CallConvs = new[] { typeof(System.Runtime.CompilerServices.CallConvCdecl) })]
+    [UnmanagedCallersOnly(CallConvs = new[] { typeof(CallConvCdecl) })]
     public static unsafe void Update(void* data, obs_data* settings)
     {
         var context = (FilterContext*)data;
@@ -187,4 +181,14 @@ public static unsafe void Update(void* data, obs_data* settings)
             context->ChannelName = ObsData.obs_data_get_string(settings, (sbyte*)sChannelNameId);
         }
     }
+
+    private unsafe struct FilterContext
+    {
+        public obs_source* Source;
+        public obs_data* Settings;
+        public bool* IsEnabled;
+
+        public sbyte* DeviceSerial;
+        public sbyte* ChannelName;
+    }
 }