ci: Fix docker image fails build #9141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Corey <[email protected]>
Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #9141 +/- ##
=======================================
Coverage 94.15% 94.15%
=======================================
Files 186 186
Lines 14726 14726
=======================================
+ Hits 13865 13866 +1
+ Misses 861 860 -1 ☔ View full report in Codecov by Sentry. |
|
@mtrezza this is ready for review |
Signed-off-by: Corey <[email protected]>
mtrezza
approved these changes
May 30, 2024
mtrezza
changed the title
|
🎉 This change has been released in version 7.1.0-alpha.10 |
|
🎉 This change has been released in version 7.1.0-beta.1 |
|
🎉 This change has been released in version 7.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Docker images aren't building because necessary executables have been removed in dependency docker images.
Closes: #9130
Approach
Install necessary executables in the build stage of the parse-server image, similar to
gitin #5861 (see #8359 for more details about reasons for only having in build stage). This shouldn't change the size of the release image.Tasks