refactor: Dry handleAuthData for safer code maintenance in the future
#9025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
Thanks for opening this pull request!
|
Moumouls
changed the title
mtrezza
requested changes
Mar 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #9025 +/- ##
==========================================
- Coverage 94.31% 93.75% -0.57%
==========================================
Files 186 186
Lines 14770 14676 -94
==========================================
- Hits 13931 13760 -171
- Misses 839 916 +77 ☔ View full report in Codecov by Sentry. |
mtrezza
changed the title
mtrezza
changed the title
handleAuthData for safer code maintenance in the future
mtrezza
requested changes
Mar 19, 2024
Signed-off-by: Manuel <[email protected]>
Signed-off-by: Manuel <[email protected]>
mtrezza
requested changes
Mar 19, 2024
|
🎉 This change has been released in version 7.0.0-alpha.30 |
|
🎉 This change has been released in version 7.1.0-alpha.1 |
|
🎉 This change has been released in version 7.1.0-beta.1 |
|
🎉 This change has been released in version 7.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Duplicated code related to an old GHSA on auth system. A quick dry refactor.
Closes: NONE
Approach
A small DRY refactor for easiest, safer futur code maintenance on auth.
Tasks