-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL with graphql-helix, graphql-ws and envelop #7394
Conversation
…-ws-envelop for envelop plugin support
Thanks for opening this PR. This seems to be in an early stage of discussion about fundamental changes in Parse Server. Such Discussions are better suited in our Community Forum while we expect feature requests on GitHub to be in a more advanced stage. After a strategic / conceptual discussion in the Community Forum, a GitHub issue is created to describe the feature, which gives more exposure and allows more people to join the discussion. The GitHub issue discussion should yield a concrete approach for implementation, which subsequently results in a PR that attempts that implementation. |
Hey @mtrezza, please interpret this pull request more as a reference to look at and talk about instead of a final solution. We are not expecting this to be merged anytime soon, that is why this is only a draft pull request. I was curious how hard or easy it is to replace the existing graphql server core without causing any breaking issues while adding a lot of benefits! We are happy to start a discussion about the benefits, drawbacks, and concerns of moving this forward! |
Sure, thanks again for this PR. Conceptual discussions are preferably started in the forum and then trickle into GitHub. This is primarily to ensure visibility and to prevent the discussion to be spread over multiple places. We want to avoid conceptual discussions (high level) to take place in a PR thread (low level). Please feel free to open a thread in the forum and reference this PR as an experimental example (PoC?). I am sure this topic will start an engaging discussion. I personally think GraphQL could play a much greater role in Parse Server, so I am happy to see any initiative in that regard. |
Thank you for the comment @mtrezza ! We've opened a discussion about that change here according to your suggestion. We opened this as draft PR just because we wanted see how it would look in code. Thanks and looking forward to discuss GraphQL in Parse in general! |
@Urigo Sure, let's keep this open in Draft for now. We do not have a PR clean-up process at the moment, so it won't be auto-closed due to inactivity. |
|
Close since Yoga is now implemented |
Hi from @the-guild-org !
We’ve recently built and open-sourced a new plugin system for GraphQL that we think would be a huge improvement for Parse developers - https://github.com/dotansimha/envelop
The goal of the library was to have a tool to handle GraphQL execution flow, allowing developers to develop, share and extend the behavior of their server implementation, in a standard, simple way. Basically the missing GraphQL execution plugin system.
Here are some possible benefits for Parse developers from the Envelop migration:
@defer
and@stream
and our new live queries implementationWe would love to hear your thoughts and feedback and see if any of the points above might be somehow helpful!
This PR is a start, we saw a couple of other things that could be updated and improved and we would love to support the Parse community better around GraphQL and would love to collaborate more in this area!
TODOs before merging