Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: liveQueryPublisher should disconnect from Redis on shutdown #7368

Closed
wants to merge 3 commits into from
Closed

test: liveQueryPublisher should disconnect from Redis on shutdown #7368

wants to merge 3 commits into from

Conversation

serchtul
Copy link

New Pull Request Checklist

Issue Description

Related issue: #7366

Approach

TODOs before merging

  • Add test cases
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK
  • ...

@mtrezza
Copy link
Member

mtrezza commented Apr 23, 2021

Thanks for creating this PR!

Interestingly, the test passes, even though it should fail, right?

Edit: I just saw that the tests did not run, I just approved them.

@mtrezza
Copy link
Member

mtrezza commented Apr 23, 2021

There are a couple of other tests failing as well. That may be due to the library mocking in your test. Could you revisit that?


const isPostgres = process.env.PARSE_SERVER_TEST_DB === 'postgres';
databaseAdapter = isPostgres
? new PostgresStorageAdapter({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if instantiating a new DB adapter with custom settings outside of the test framework could have any side effects regarding cleanup, etc.

@dplewis ?

@mtrezza
Copy link
Member

mtrezza commented Sep 3, 2021

⚠️ Important change for merging PRs from Parse Server 5.0 onwards!

We are planning to release the first beta version of Parse Server 5.0 in October 2021.

If a PR contains a breaking change and is not merged before the beta release of Parse Server 5.0, it cannot be merged until the end of 2022. Instead it has to follow the Deprecation Policy and phase-in breaking changes to be merged during the course of 2022.

One of the most voiced community feedbacks was the demand for predictability in breaking changes to make it easy to upgrade Parse Server. We have made a first step towards this by introducing the Deprecation Policy in February 2021 that assists to phase-in breaking changes, giving developers time to adapt. We will follow-up with the introduction of Release Automation and a branch model that will allow breaking changes only with a new major release, scheduled for the beginning of each calendar year.

We understand that some PRs are a long time in the making and we very much appreciate your contribution. We want to make it easy for PRs that contain a breaking change and were created before the introduction of the Deprecation Policy. These PRs can be merged with a breaking change without being phased-in before the beta release of Parse Server 5.0. We are making this exception because we appreciate that this is a time of transition that requires additional effort from contributors to adapt. We encourage everyone to prepare their PRs until the end of September and account for review time and possible adaptions.

If a PR contains a breaking change and should be merged before the beta release, please mention @parse-community/server-maintenance and we will coordinate with you to merge the PR.

Thanks for your contribution and support during this transition to Parse Server release automation!

@serchtul serchtul closed this by deleting the head repository Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants