-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: liveQueryPublisher should disconnect from Redis on shutdown #7368
test: liveQueryPublisher should disconnect from Redis on shutdown #7368
Conversation
Thanks for creating this PR! Interestingly, the test passes, even though it should fail, right? Edit: I just saw that the tests did not run, I just approved them. |
There are a couple of other tests failing as well. That may be due to the library mocking in your test. Could you revisit that? |
|
||
const isPostgres = process.env.PARSE_SERVER_TEST_DB === 'postgres'; | ||
databaseAdapter = isPostgres | ||
? new PostgresStorageAdapter({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if instantiating a new DB adapter with custom settings outside of the test framework could have any side effects regarding cleanup, etc.
@dplewis ?
|
New Pull Request Checklist
Issue Description
Related issue: #7366
Approach
TODOs before merging