Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wildcard classname in cloud triggers #7360

Closed
wants to merge 4 commits into from
Closed

Support wildcard classname in cloud triggers #7360

wants to merge 4 commits into from

Conversation

uzaysan
Copy link

@uzaysan uzaysan commented Apr 19, 2021

Issue Description

This pull request solves this problem
https://community.parseplatform.org/t/support-wildcard-classname-in-cloud-triggers/1584

Related issue: #7361

Approach

If user set trigger for class "*", that trigger will be called for every class unless class has its own trigger.

TODOs before merging

  • Add test cases

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #7360 (7577199) into master (94b7b32) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7360      +/-   ##
==========================================
- Coverage   93.92%   93.89%   -0.03%     
==========================================
  Files         181      181              
  Lines       13195    13198       +3     
==========================================
- Hits        12393    12392       -1     
- Misses        802      806       +4     
Impacted Files Coverage Δ
src/triggers.js 94.98% <100.00%> (+0.03%) ⬆️
src/batch.js 91.37% <0.00%> (-1.73%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.59% <0.00%> (-0.66%) ⬇️
src/RestWrite.js 93.76% <0.00%> (-0.16%) ⬇️
src/ParseServerRESTController.js 98.50% <0.00%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b7b32...7577199. Read the comment docs.

@uzaysan
Copy link
Author

uzaysan commented Apr 19, 2021

I tried to create class with the name * by using masterKey. But I got an error from SchemaController. Spesifically from here. And I didnt add class name validation. I guess its not necesarry. Parse server already rejects requests for this class name *.

Also I didn't change addTrigger function since it only checks for pre-defined classes.

@uzaysan
Copy link
Author

uzaysan commented Apr 19, 2021

This test fails.
- Unhandled promise rejection: error: deadlock detected (line 1155)
But I believe it's not related to this pr.

@mtrezza mtrezza marked this pull request as draft April 19, 2021 12:14
@mtrezza
Copy link
Member

mtrezza commented Apr 20, 2021

Note for reviewers: there is an ongoing discussion in #7361 about how the feature should be implemented.

@mtrezza
Copy link
Member

mtrezza commented Sep 3, 2021

⚠️ Important change for merging PRs from Parse Server 5.0 onwards!

We are planning to release the first beta version of Parse Server 5.0 in October 2021.

If a PR contains a breaking change and is not merged before the beta release of Parse Server 5.0, it cannot be merged until the end of 2022. Instead it has to follow the Deprecation Policy and phase-in breaking changes to be merged during the course of 2022.

One of the most voiced community feedbacks was the demand for predictability in breaking changes to make it easy to upgrade Parse Server. We have made a first step towards this by introducing the Deprecation Policy in February 2021 that assists to phase-in breaking changes, giving developers time to adapt. We will follow-up with the introduction of Release Automation and a branch model that will allow breaking changes only with a new major release, scheduled for the beginning of each calendar year.

We understand that some PRs are a long time in the making and we very much appreciate your contribution. We want to make it easy for PRs that contain a breaking change and were created before the introduction of the Deprecation Policy. These PRs can be merged with a breaking change without being phased-in before the beta release of Parse Server 5.0. We are making this exception because we appreciate that this is a time of transition that requires additional effort from contributors to adapt. We encourage everyone to prepare their PRs until the end of September and account for review time and possible adaptions.

If a PR contains a breaking change and should be merged before the beta release, please mention @parse-community/server-maintenance and we will coordinate with you to merge the PR.

Thanks for your contribution and support during this transition to Parse Server release automation!

@mtrezza mtrezza deleted the branch parse-community:master October 26, 2021 16:58
@mtrezza mtrezza closed this Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants