Email Validation #627

flovilmart · 2016-02-24T15:06:13Z

facebook-github-bot · 2016-02-24T16:34:17Z

@flovilmart updated the pull request.

flovilmart · 2016-02-24T17:07:10Z

@drew-gross I've reopened here with a proper rebase on master.

drew-gross · 2016-02-24T18:28:50Z

src/Adapters/Email/SimpleMailgunAdapter.js

+	      "" +
+	      "Click here to confirm it:\n" + link;
+			return sendMail({ 
+        to:user.email, 


This will have to be user.get('email') I believe. Tests for the actual adapter is one thing I had punted on in the original PR :p

I pass the request body there. so that's a plain JS object.

Oh man me and @gfosco and @nlutsenko had a big debate about this a couple days ago. Me and @gfosco would rather we give Parse.Objects to adapters and @nlutsenko would rather we give them raw json. Would you like to weigh in on that discussion?

Also cc @lacker, since he had an opinion on this yesterday as well.
I feel quite strongly about not requiring people to use Parse.Objects here, since it provides absolutely no benefit.

In push adapter we pass raw objects for the installations.
Passing Parse.Objects would leave the opportunity to CRUD, do we want to allow that?

My standing is that for places where we want to allow CRUD, like in Parse.Cloud things - it makes an absolute sense to do this.
Otherwise, where this is not the intention of the adapter - you can still do it by creating a Parse.Object from JSON object that you get in the adapter, but it's in your best interest to actually not do it.

My standing is that Parse.Object is a more consistent, more well known, and generally better interface for interacting with data, and that if we want to prevent mutations and/or queries in a particular adapter, we should make an immutable version of Parse.Object instead of changing the entire interface.

For the push adapter I would rather have it accept Parse.Installation but I didn't catch that change before it was merged. We can still consistently use Parse.Objects for future adapters if we decide that is the way we want to go.

so the vote is 2 vs 2 we need a tie breaker.

facebook-github-bot · 2016-02-24T19:13:14Z

@flovilmart updated the pull request.

gfosco · 2016-02-26T09:52:03Z

spec/ParseGeoPoint.spec.js

@@ -24,7 +24,7 @@ describe('Parse.GeoPoint testing', () => {
        });
      }
    });
-  });
+  }, 60000);


What's the 60000s for? Tried looking up jasmine docs, they're useful for examples but not much of an api reference..

Timeout on this test. I think this accommodates an old thing, since these tests don't timeout anymore but fail in a flaky way. Meaning - please remove?

Pretty sure we have a global 2s timeout for each test already, defined at the top of helper.js

I'll remove them, those were to bypass the failures that we had for a while in the geo point tests.

facebook-github-bot · 2016-02-26T13:31:15Z

@flovilmart updated the pull request.

facebook-github-bot · 2016-02-27T00:29:14Z

@flovilmart updated the pull request.

drew-gross · 2016-02-27T00:37:07Z

src/Adapters/Logger/FileLoggerAdapter.js

    super();
-
+    if (options && !options.logsFolder) {
+      throw "FileLoggerAdapter requires logsFolder";


This is a backwards incompatible change

Yes it is, but unlikely to hurt anyone.
in index.js loggerAdapter is defaulted to undefined and logsFolder is the only option.
that would throw only if the user did loggerAdatper: {}

I could remove but it's part of the validation for the adapter loaders

That seems like a weak justification for breaking compatibility to me. I'd suggest documenting that it's required, and warn if it's not supplied, but not actually fail if it's not supplied.

facebook-github-bot · 2016-02-27T15:52:19Z

@flovilmart updated the pull request.

facebook-github-bot · 2016-02-27T16:18:14Z

@flovilmart updated the pull request.

drew-gross · 2016-02-27T19:37:20Z

src/Adapters/Push/OneSignalPushAdapter.js

@@ -18,6 +18,10 @@ export class OneSignalPushAdapter extends PushAdapter {
    this.validPushTypes = ['ios', 'android'];
    this.senderMap = {};
    this.OneSignalConfig = {};
+    const { oneSignalAppId, oneSignalApiKey } = pushConfig;
+    if (!oneSignalAppId || !oneSignalApiKey) {
+      throw "Trying to initialiazed OneSignalPushAdapter without oneSignalAppId or oneSignalApiKey";


typo: initialize

facebook-github-bot · 2016-02-27T19:47:15Z

@flovilmart updated the pull request.

drew-gross · 2016-02-27T19:49:11Z

src/Controllers/UserController.js

+        // Need direct database access because verification token is not a parse field
+        return coll.findOne({
+          username: username,
+          _email_reset_token: token,


I think for compatibility with databases migrated from Parse.com the name needs to be _perishable_token

drew-gross · 2016-02-27T20:01:32Z

Sweet, looks like this is getting pretty close to ready. Don't forget to resend the email and set emailVerified to false if the user changes their email.

flovilmart · 2016-02-27T20:02:38Z

Oh right! For the UserController, do you want me to support multiple adapters right away?

facebook-github-bot · 2016-02-27T20:04:14Z

@flovilmart updated the pull request.

drew-gross · 2016-02-27T20:10:10Z

I think we can cross that bridge when we get to it. I'm just expressing my concern :p

flovilmart · 2016-02-27T20:10:43Z

I thought about it too, then I remembered 'easily fixable' :)

tanmays · 2016-03-07T11:10:35Z

If all files are located at their original location i.e. parse-server/public_html and parse-server/views you don't need to specify customPages nor modify choose_password file or add any extension to it.

432player · 2016-03-07T11:22:01Z

Thank @tanmays

Now I get this error:
Uncaught internal server error. { [Error: ENOENT: no such file or directory, open '/app/node_modules/parse-server/views/choose_password']

I still have the 'public_html' and it's content and 'views' and it's content inside my parse-server-example directory..
I've replaced SERVER_URL with http://medidate.herokuapp.com/parse inside my 'choose_password' file (which is inside views/)

It's like he's not even looking inside my own 'choose_password' file..

tanmays · 2016-03-07T11:34:54Z

If you are using parse-server-example, the public_html and views folder needs to be inside the parse-server dependancy. Their path should be something like this parse-server-example/node_modules/parse-server/views/

There was a bug in v2.1.4 which didn't include these folders with the npm release. You should probably wait for v2.1.5.

432player · 2016-03-07T11:37:34Z

@tanmays Thank you for your help. We will wait for the new release as you suggest.
Cheers!

btate · 2016-03-07T15:14:48Z

Just a heads up. I saw some parse errors with code 100, can't connect to parse API when I was querying from my cloud functions after I set the SERVER_URI in my environment variables. For some reason using the public server url for the serverURL configuration value was causing this. I updated my configuration to use localhost for serverURL and the issue went away. Not sure if this is just a me problem, but if anyone else sees it, try this fix.

serverURL: 'http://localhost:' + port + '/parse',
publicServerURL: process.env.SERVER_URI || 'http://localhost:' + port + '/parse',

flovilmart · 2016-03-07T15:26:11Z

The public server URL should be a public facing URL if you're not developing, otherwise, you can remove process.env.SERVER_URI || and just set it 'http://localhost:' + port + '/parse'

btate · 2016-03-07T15:31:24Z

The publicServerURL is fine. It was the serverURL that was breaking if it wasn't local host. Just documenting this issue in case anyone else sees it.

flovilmart · 2016-03-07T15:32:00Z

Oh right! Thanks!

thamer898 · 2016-03-07T16:27:21Z

Hello

@drew-gross i have a parse server version 2.1.4 so i want to implement user reset password feature using mailgun can you help me with that ?

Regards

drew-gross · 2016-03-07T19:44:36Z

Email validation in Parse Server is still experimental. If you want to try it out, you can read this thread to get an idea of how to enable it, but there are no docs yet.

thamer898 · 2016-03-07T20:02:01Z

Hello @drew-gross

when the reset user password feature will be enabled ?

regards

432player · 2016-03-09T09:38:50Z

Hey @drew-gross
Everything's almost working for us for the reset password but as @tanmays says it can't find the relevant files and folders on the parse-server (version 2.1.4). Here is the log from Heroku
Uncaught internal server error. { [Error: ENOENT: no such file or directory, open '/app/node_modules/parse-server/views/choose_password']
Any ideas? Perhaps a timeline for a new version that exposes the files and folders correctly?

btate · 2016-03-09T12:48:18Z

@432player I got that working by copying the custom files out of my old cloud code and setting the custom pages in my configuration. You could also just download the 2.1.4 branch of parse-server and pull those files out and put them somewhere public. I believe you'll need to follow @tanmays advice about the choose_password file.

432player · 2016-03-09T17:23:55Z

Hey @btate thanks for your input! Can you further explain how to copy the custom files (invalid_link.html, password_reset_success.html, verify_email_success.html,choose_password) into the configuration.
And then how to reference them with hope that it will find the files.
Thanks!

btate · 2016-03-09T19:14:34Z

@432player, you just have to copy those files out of the node module's public_html and view folders and put them somewhere public facing. Then you set the custom page urls in the api configuration.

var api = new ParseServer({
    ...other options
    appName: 'Your app name here',
    publicServerURL: '<same as serverURL>',
    // Optional only if you want to provide you own pages hosted on your web server
    customPages: {
          invalidLink: 'http://yourdomain.com/invalid_link.html',
          verifyEmailSuccess: 'http://yourdomain.com/verify_email_success.html',
          choosePassword: 'http://yourdomain.com/choose_password.html',
          passwordResetSuccess: 'http://yourdomain.com/password_reset_success.html'
    }
});

432player · 2016-03-09T19:18:59Z

@btate Is there any way to do so in heroku with the same deployment?

btate · 2016-03-09T19:21:34Z

@432player my custom pages are in another web application separate from my services application. So you'll have to figure out where public pages go in your node application using parse-server. I'm not sure where they go. I'd imagine there's just a public_html folder or something that node recognizes.

432player · 2016-03-09T21:09:33Z

@btate Thank you so much! we finally got this working. You were right indeed.
It's important to know that the public_html folder in the parse-server at this point does not run the html files or is not public facing. which means they are unreachable.
To get this eventually working the html files need to be self hosted somewhere publicly and the links replaced accordingly in the customPages the emailAdapter has.
Cheers! and good luck everyone

flovilmart · 2016-03-09T21:10:43Z

the html_pages should be visible with 2.1.5. But you can still use the customPages as it's nicer!

mtrezza · 2016-03-11T00:35:15Z

I've set the parse server configuration and made the custom pages publicly accessible. However after sending the form choose_password I always get redirected to the invalid_link page. As if the token was invalid.

Here's the server config:

// Start Parse server
var api = new ParseServer({
    appName: '<removed/>',
    databaseURI: 'mongodb://<removed/>',
    cloud: process.env.CLOUD_CODE_MAIN || __dirname + '/cloud/main.js',
    appId: '<removed/>',
    masterKey: '<removed/>',
    serverURL: 'https://<removed/>/parse',
    publicServerURL: 'https://<removed/>/parse',
    fileKey: '<removed/>',
    filesAdapter: new S3Adapter(<removed/>),
    push: {<removed/>},
    emailAdapter: SimpleMailgunAdapter({
        apiKey: '<removed/>',
        domain: '<removed/>',
        fromAddress: '<removed/>'
    }),
    customPages: {
        invalidLink: 'http://<removed/>/invalid_link.html',
        verifyEmailSuccess: 'http://<removed/>/verify_email_success.html',
        choosePassword: 'http://<removed/>/choose_password.html',
        passwordResetSuccess: 'http://<removed/>/password_reset_success.html'
    }
});

In choose_password I only modified this line to:
var base = 'https://<removed/>/parse';

What am I missing here?

UPDATE: Had a wrong path in the base var in choose_password. ".heroku.com" instead of ".herokuapp.com". Works fine now.

rafapetter · 2016-03-18T20:42:50Z

@flovilmart after reading this thread, I still have 2 questions:

when using customPages on another domain, what are the steps? I'm getting those 4 pages, putting them accessible on the new domain and changing the publicServerURL to point to that domain.
when not using customPages, everything is works fine, but is accepting any length of password, any idea on how to restrict to a password policy?

facebook-github-bot · 2016-03-18T21:31:55Z

@flovilmart updated the pull request.

seonman · 2016-03-22T23:10:35Z

I could successfully enable email verification and reset password by adding required parameters in ParseServer initializer. However, I cannot find how to change the Email Templates (the Text templates to be sent in the email), like "Verification Email Subject", "Verification Email Body", "Password Reset Subject", etc.
Where can I find those files?

tanmays · 2016-03-26T07:25:15Z

@seonman Afaik there's no way to provide templates for reset and welcome email right now. You should probably open up a separate issue as a feature request.

gowridev · 2016-04-06T12:54:40Z

@tanmays I have configured email adapter in parse server. How to write parse cloud code for parse server? do we need to have heroku account for parse cloud code?

tanmays · 2016-04-07T14:52:02Z

@gowridev no need to write cloud code for reset email and verify email functions. For any other custom events you'll probably want to use official mailgun client https://github.com/1lobby/mailgun-js

techyrajeev · 2016-10-20T13:48:34Z

Hi @tanmays
is there any way I can provide custom page for verify email and reset password not just verify email success or reset password success pages?
What configuration I need to set up?
Please help.

AnChiChang · 2017-05-03T08:10:58Z

hi @tanmays

I am using parse-server-example.
I had implemented emailAdapter, and customPages. I will receive reset password from mailgun. However, after click the link in the mail. The web display Cannot GET /apps/appid/request_password_reset?token=token&username=username. Therefore, I have to implement my app.get(/request_password_reset) function by myself? or can use Parse Server default html and forms?

facebook-github-bot added the GH Review: review-needed label Feb 24, 2016

flovilmart closed this Feb 24, 2016

flovilmart reopened this Feb 24, 2016

flovilmart closed this Feb 24, 2016

flovilmart reopened this Feb 24, 2016

flovilmart changed the title ~~Mail adapter~~ Email Validation Feb 24, 2016

flovilmart closed this Feb 24, 2016

flovilmart reopened this Feb 24, 2016

drew-gross reviewed Feb 24, 2016
View reviewed changes

gfosco reviewed Feb 26, 2016
View reviewed changes

drew-gross reviewed Feb 27, 2016
View reviewed changes

btate mentioned this pull request Mar 7, 2016

reset user Password #527

Closed

flovilmart mentioned this pull request Mar 11, 2016

requestPasswordResetForEmailInBackground error #972

Closed

Email Validation #627

Email Validation #627

Conversation

flovilmart commented Feb 24, 2016

facebook-github-bot commented Feb 24, 2016

flovilmart commented Feb 24, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facebook-github-bot commented Feb 24, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facebook-github-bot commented Feb 26, 2016

facebook-github-bot commented Feb 27, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facebook-github-bot commented Feb 27, 2016

facebook-github-bot commented Feb 27, 2016

Choose a reason for hiding this comment

facebook-github-bot commented Feb 27, 2016

Choose a reason for hiding this comment

drew-gross commented Feb 27, 2016

flovilmart commented Feb 27, 2016

facebook-github-bot commented Feb 27, 2016

drew-gross commented Feb 27, 2016

flovilmart commented Feb 27, 2016

tanmays commented Mar 7, 2016

432player commented Mar 7, 2016

tanmays commented Mar 7, 2016

432player commented Mar 7, 2016

btate commented Mar 7, 2016

flovilmart commented Mar 7, 2016

btate commented Mar 7, 2016

flovilmart commented Mar 7, 2016

thamer898 commented Mar 7, 2016

drew-gross commented Mar 7, 2016

thamer898 commented Mar 7, 2016

432player commented Mar 9, 2016

btate commented Mar 9, 2016

432player commented Mar 9, 2016

btate commented Mar 9, 2016

432player commented Mar 9, 2016

btate commented Mar 9, 2016

432player commented Mar 9, 2016

flovilmart commented Mar 9, 2016

mtrezza commented Mar 11, 2016

rafapetter commented Mar 18, 2016

facebook-github-bot commented Mar 18, 2016

seonman commented Mar 22, 2016

tanmays commented Mar 26, 2016

gowridev commented Apr 6, 2016

tanmays commented Apr 7, 2016

techyrajeev commented Oct 20, 2016

AnChiChang commented May 3, 2017 • edited Loading

AnChiChang commented May 3, 2017 •

edited

Loading