Re-enable and slightly rewrite flaky GeoPoint test. #588
Conversation
nlutsenko
force-pushed
the
nlutsenko.geo.tests
branch
from
a7b3aa6 to
21e6e43
Compare
|
@nlutsenko updated the pull request. |
nlutsenko
force-pushed
the
nlutsenko.geo.tests
branch
from
21e6e43 to
34e97b1
Compare
|
@nlutsenko updated the pull request. |
|
this is now failing on: |
|
Yup, can see that. Any idea on what is going on? I have no idea on how to debug this at this point :( |
|
Not more than you, maybe put a done() on The failure case. Bump the allowed time for processing up? Are those queries hyper slow in mongo? Should we add indexing on all fields? |
|
Querying the geo point is when the geo index is created, which could be slow (although I wouldn't expect it to take 10 seconds) Maybe crank up the allowed time to like 10 minutes and add some measurement on how long it takes. |
|
The createIndex is 'blocking', is that intended? We should probably do that when app is created or upon the 1st connection in a non-blocking way? |
|
Background index creation at either class creation time or field addition time is probably the way to go. However, I believe mongo requires the index before you can do geo queries so if that is in fact the issue with the test, it wouldn't fix it. |
|
@drew-gross @nlutsenko with write access to the repo, you can run travis restart that will help instead of open/close. I'm kinda opening/closing all the times ;( |
nlutsenko
force-pushed
the
nlutsenko.geo.tests
branch
from
34e97b1 to
37116a8
Compare
|
@nlutsenko updated the pull request. |
nlutsenko
force-pushed
the
nlutsenko.geo.tests
branch
from
37116a8 to
41cf260
Compare
|
@nlutsenko updated the pull request. |
|
https://travis-ci.org/ParsePlatform/parse-server/jobs/111894700 had a failure for trying to create a 2nd geopoint on a class, which seems to me to indicate that it's racing with the teardown from the previous test, which is the one that checks to make sure that saving two geo points fails. The test this diff is investigating was also right after that test before it was disabled. |
M? Not sure I got you... Also, yes, I am investigating the race condition on teardown. |
Do not review yet, exists purely to trigger Travis-CI back and forth.