Update PostgresStorageAdapter.js #2082
Conversation
vitaly-t
commented
Jun 16, 2016
vitaly-t
commented
- correcting some queries
- correcting spellings
- adding notes
* correcting some queries * correcting spellings * adding notes
ghost
added
the
|
It looks like this PR changes the whitespace for the entire file, maybe your editor did that automatically. Could you undo that? It both makes it hard to tell what actually changed, and make |
Current coverage is 90.34%@@ master #2082 diff @@
==========================================
Files 93 93
Lines 6717 6715 -2
Methods 1191 1190 -1
Messages 0 0
Branches 1411 1411
==========================================
- Hits 6174 6067 -107
- Misses 543 648 +105
Partials 0 0
|
|
Damn, I've made so many small changes, and to get get rid of the changed white spaces I would have to re-do everything. That sucks. Do you have tests for that to confirm the correctness? I really would rather not re-do everything. |
|
@vitaly-t shift-tab is your friend, can't you simply fix that with a formatter/linter/manually in no time? Try making tab spacing 2 in your IDE. |
|
Yep, I don't know what editor you are using, but in sublime text you can just set the indentation level and then re-indent everything. We have fairly comprehensive tests so I'm pretty sure your code is correct, but I'd like to look at what exactly changed as well, which is hard when the whitespace changes make it look like everything chagned. If you don't want to do it, I could do the re-indentation myself, but you would lose attribution. |
|
I'm using WebStorm. I would pay better attention to it next time, but re-doing all changes now is kind of late :| |
|
It looks like you have just switched the file from 2 space indenting to 4 space indenting, if you just reformat it back into two space indenting and commit that the diff should then work ok? |
|
No problem, I'll close this and apply the same changes in a new PR. |
