Postgres exclude failing tests #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More passing postgres tests Handle schema updates, and $in for non array columns remove authdata from user and implement ensureUniqueness Make some tests work, detect existing classes Throw proper error for unique index violation fix findOneAndUpdate Support more types support more type Support boolean, fix _rperm/_wperm, add TODO Support string types and also simplify tests Move operator flattening into Parse Server and out of mongo adapters Move authdata transform for create into Parse Server Move authdata transforms completely in to Parse Server Fix test setup inline addSchema Inject default schema to response from DB adapter
ghost
added
the
|
@drew-gross updated the pull request. |
|
@drew-gross updated the pull request. |
|
@drew-gross updated the pull request. |
1 similar comment
|
@drew-gross updated the pull request. |
Current coverage is 92.00%@@ master #2081 diff @@
==========================================
Files 93 93
Lines 6717 6765 +48
Methods 1191 1191
Messages 0 0
Branches 1411 1430 +19
==========================================
+ Hits 6174 6224 +50
+ Misses 543 541 -2
Partials 0 0
|
| @@ -51,7 +50,7 @@ describe('parseObjectToMongoObjectForCreate', () => { | |||
|
|
|||
| //TODO: object creation requests shouldn't be seeing __op delete, it makes no sense to | |||
| //have __op delete in a new object. Figure out what this should actually be testing. | |||
| notWorking('a delete op', (done) => { | |||
| xit('a delete op', (done) => { | |||
There was a problem hiding this comment.
Yep, there were a handful of tests that were marked with notWorking from the start. xit is just notWorking but also adds some useful output when the tests are run.
|
LGTM |
| } | ||
| } | ||
|
|
||
| const transformAuthData = (className, object, schema) => { |
There was a problem hiding this comment.
...handled here, in Parse Server, not the DB adapter. The eventual plan is to somewhat duplicate the mongo format, so each type of auth data gets it's own column, like _auth_data_facebook and so-on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
it_exclude_dbswhich turns intoxitfor DBs that don't work with this interface.Inline addSchema, which was only used in one place
Do authData and update operator transformation in Parse Server, not DB adapter.
Implement more types and duplicate value detection in Postgres adapter.