-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: pin all package versions. #2040
Comments
I fully agree with you, since the problem with mongodb package I followed your valuable advice: npm shrinkwrap, this should be standard, thus avoiding new problems of this kind - which takes our sleep. |
Cool. Consensus in slack is to pin as well. I will make a PR. |
flovilmart
pushed a commit
that referenced
this issue
Jun 16, 2016
* Pin all package versions Closes #2040 * Pin packages to a working version * Drop extra stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have now had 2 issues where a "patch" upgrade in a dependency broke Parse Server. Once when
mongodb
package updated from2.1.18
to2.1.19
and once whendeepcopy
package updated from0.6.1
to0.6.2
. We should consider pinning all dependencies to prevent issues like this in the future.The downside is that Parse Server will be less able to share dependencies with other packages, causing an increase in code size.
Thoughts?
I'm going to enable https://greenkeeper.io/ either way, which will hopefully help with the issue.
The text was updated successfully, but these errors were encountered: