Skip to content

Commit

Permalink
Update PostgresStorageAdapter.js (#2093)
Browse files Browse the repository at this point in the history
If it really needs to reject with `undefined`, then this is the right way. Usually one just returns the result, let the caller provide the `.catch` ;)

This way real errors can be swallowed, not very good ;)
  • Loading branch information
vitaly-t authored and drew-gross committed Jul 9, 2016
1 parent a55466f commit a92b23b
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions src/Adapters/Storage/Postgres/PostgresStorageAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -220,13 +220,9 @@ export class PostgresStorageAdapter {
// this adapter doesn't know about the schema, return a promise that rejects with
// undefined as the reason.
getClass(className) {
return this._client.query('SELECT * FROM "_SCHEMA" WHERE "className"=$<className>', { className })
.then(result => {
if (result.length === 1) {
return result[0].schema;
} else {
return this._client.one('SELECT * FROM "_SCHEMA" WHERE "className"=$<className>', { className }, res=>res.schema)
.catch(error => {
throw undefined;
}
});
}

Expand Down

0 comments on commit a92b23b

Please sign in to comment.