Fix: Proper handling of arrays for cloud validator (#7178)

* fix: proper handling of arrays for cloud validator * Update CloudCode.Validator.spec.js
parse-community · Feb 11, 2021 · 27d56f0 · 27d56f0
1 parent 7f47b04
commit 27d56f0
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/spec/CloudCode.Validator.spec.js b/spec/CloudCode.Validator.spec.js
@@ -264,6 +264,24 @@ describe('cloud validator', () => {
       });
   });
 
+  it('set params type allow array', async () => {
+    Parse.Cloud.define(
+      'hello',
+      () => {
+        return 'Hello world!';
+      },
+      {
+        fields: {
+          data: {
+            type: Array,
+          },
+        },
+      }
+    );
+    const result = await Parse.Cloud.run('hello', { data: [{ foo: 'bar' }] });
+    expect(result).toBe('Hello world!');
+  });
+
   it('set params type', done => {
     Parse.Cloud.define(
       'hello',

diff --git a/src/triggers.js b/src/triggers.js
@@ -710,9 +710,8 @@ function builtInTriggerValidator(options, request) {
         }
         if (opt.type) {
           const type = getType(opt.type);
-          if (type == 'array' && !Array.isArray(val)) {
-            throw `Validation failed. Invalid type for ${key}. Expected: array`;
-          } else if (typeof val !== type) {
+          const valType = Array.isArray(val) ? 'array' : typeof val;
+          if (valType !== type) {
             throw `Validation failed. Invalid type for ${key}. Expected: ${type}`;
           }
         }