refactor: Lint project and remove deprecated code #43

cbaker6 · 2023-06-18T16:16:10Z

Pull Request

Report security issues confidentially.
Any contribution is under this license.
Link this pull request to an issue.

Issue

The project isn't linted

Closes: #44

Approach

Lint the project
~~Add babel dev dependencies~~
~~Update CI to test for successful lint~~
Replace deprecated substr with substring
Refactor rotateEncryptionKey() to use async/await instead of promise
Let dependabot update action versions weekly

Tasks

Ensure tests pass
Change repo settings to require new tests

parse-github-assistant · 2023-06-18T16:16:13Z

Thanks for opening this pull request!

codecov · 2023-06-18T16:29:33Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (09180e8) 90.83% compared to head (01c7283) 93.44%.
Report is 1 commits behind head on main.

Files	Patch %	Lines
index.js	97.36%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   90.83%   93.44%   +2.60%     
==========================================
  Files           1        1              
  Lines         131      122       -9     
==========================================
- Hits          119      114       -5     
+ Misses         12        8       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…pter into lint

cbaker6 · 2023-06-18T17:46:09Z

@mtrezza @dblythy Can either revert semantic-release as suggested in #45 or merge this PR which currently uses the previous version of semantic-release to pass the CI

In the repo settings you should add protections for the following passing tests:

Lint
Node 14
Node 16
Node 18
Node 19

Remove the following as they are replaced by the aforementioned tests:

test (14)
test (16)
test (18)

…pter into lint

mtrezza · 2023-06-18T20:15:30Z

Could you please resolve any conflicts; and keep the semantic release version of the main branch, it should work with #46.

cbaker6 · 2023-06-18T21:24:29Z

My reason for opening for #45 is because it results in the following when trying to install on a local machine:

npm WARN old lockfile 
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile 
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile 
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @parse/[email protected]
npm WARN Found: [email protected]
npm WARN node_modules/semantic-release
npm WARN   peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/[email protected]
npm WARN   6 more (@semantic-release/changelog, @semantic-release/npm, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/[email protected]
npm WARN node_modules/@semantic-release/commit-analyzer
npm WARN   @semantic-release/commit-analyzer@"^8.0.0" from [email protected]
npm WARN   node_modules/semantic-release
npm WARN   1 more (the root project)
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @parse/[email protected]
npm WARN Found: [email protected]
npm WARN node_modules/semantic-release
npm WARN   peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/[email protected]
npm WARN   6 more (@semantic-release/changelog, @semantic-release/npm, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer semantic-release@">=15.8.0 <18.0.0" from @semantic-release/[email protected]
npm WARN node_modules/@semantic-release/changelog
npm WARN   dev @semantic-release/changelog@"5.0.1" from the root project
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @parse/[email protected]
npm WARN Found: [email protected]
npm WARN node_modules/semantic-release
npm WARN   peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/[email protected]
npm WARN   6 more (@semantic-release/changelog, @semantic-release/npm, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/[email protected]
npm WARN node_modules/@semantic-release/npm
npm WARN   @semantic-release/npm@"^7.0.0" from [email protected]
npm WARN   1 more (the root project)
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @parse/[email protected]
npm WARN Found: [email protected]
npm WARN node_modules/semantic-release
npm WARN   peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/[email protected]
npm WARN   6 more (@semantic-release/changelog, @semantic-release/npm, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/[email protected]
npm WARN node_modules/@semantic-release/git
npm WARN   dev @semantic-release/git@"9.0.0" from the root project
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @parse/[email protected]
npm WARN Found: [email protected]
npm WARN node_modules/semantic-release
npm WARN   peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/[email protected]
npm WARN   6 more (@semantic-release/changelog, @semantic-release/npm, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/[email protected]
npm WARN node_modules/@semantic-release/github
npm WARN   @semantic-release/github@"^7.0.0" from [email protected]
npm WARN   1 more (the root project)
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @parse/[email protected]
npm WARN Found: [email protected]
npm WARN node_modules/semantic-release
npm WARN   peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/[email protected]
npm WARN   6 more (@semantic-release/changelog, @semantic-release/npm, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer semantic-release@">=15.8.0 <18.0.0" from @semantic-release/[email protected]
npm WARN node_modules/@semantic-release/release-notes-generator
npm WARN   @semantic-release/release-notes-generator@"^9.0.0" from [email protected]
npm WARN   1 more (the root project)
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: @parse/[email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/semantic-release
npm ERR!   dev semantic-release@"21.0.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/[email protected]
npm ERR! node_modules/@semantic-release/commit-analyzer
npm ERR!   dev @semantic-release/commit-analyzer@"8.0.1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

If you know of a better way without force installing, let me know, but the errors seem to point to wanting newer versions than what's in the package.json and package-lock

mtrezza · 2023-06-18T21:30:02Z

What Node and npm version are you running? I tried with Node 16 and 18 and it worked fine. It really just needs to run in our CI, and that's it. This release framework is our internal tool. Check here:

https://github.com/parse-community/parse-server-fs-adapter/actions/runs/5305463515/jobs/9602438824

cbaker6 · 2023-06-18T21:33:19Z

I'm running 18.16.0. I tried installing using npm i -E [email protected]

mtrezza · 2023-06-18T21:35:26Z

The main branch works it seems, so why are you trying to install the dependency explicitly? If you use the main branch and then run npm i it should work I guess.

cbaker6 · 2023-06-18T21:43:21Z

It appears to me that dependabot allowed an incorrect update in #41 and somehow forced an update to the package-lock. The warnings and errors in #43 (comment) look explicit and state a number of problems like peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/[email protected].

#41 updated from [email protected] to [email protected] which are outside the peer dependency windows which is what I mentioned in #45. It seems if that update was to be done properly, other semantic-release updates should have been done at the same time.

In addition, the parse-server receives way more updates than this repo and it's versions aren't this high: https://github.com/parse-community/parse-server/blob/9674d4a2c0a9d0cda112056a6a2b1629931f37a3/package.json#L75-L107

cbaker6 · 2023-06-18T22:08:14Z

The main branch works it seems, so why are you trying to install the dependency explicitly?

This PR requires babel/lint to be installed, installing using npm i will either revert semantic-release version to a compatible one (the current commit of this PR) or result in the errors mentioned in #43 (comment). I suspect the reasons for the this is what I mentioned in #43 (comment)

package.json

…pter into lint

cbaker6 · 2024-01-22T04:08:57Z

Ready for review...

In the repo settings you should add protections for the following passing tests:

ci/Node 14
ci/Node 16
ci/Node 18

Remove the following as they are replaced by the aforementioned tests:

test (14)
test (16)
test (18)

parseplatformorg · 2024-02-18T12:27:43Z

🎉 This change has been released in version 3.0.0

cbaker6 added 3 commits June 18, 2023 10:35

add babel and linter

2fb584f

fix lint errors

5f41b16

add lint check to CI

0ef115f

cbaker6 marked this pull request as draft June 18, 2023 16:20

cbaker6 added 2 commits June 18, 2023 12:25

update ci files

347f7fb

Update ci.yml

e1a7ab8

cbaker6 added 5 commits June 18, 2023 12:32

Update ci.yml

8cee9d3

use lockfile version 1

d6a4461

Merge branch 'lint' of https://github.com/cbaker6/parse-server-fs-ada…

476b543

…pter into lint

update to async/await

4ecd71b

replace deprecated substr with substring

2e88d02

cbaker6 marked this pull request as ready for review June 18, 2023 17:43

cbaker6 added 4 commits June 18, 2023 14:22

Update ci to use node version for name

e8a84a1

fix ci cache keys

6bc19cc

let dependabot keep actions up-to-date

f714056

Merge branch 'lint' of https://github.com/cbaker6/parse-server-fs-ada…

f5390f5

…pter into lint

mtrezza changed the title ~~refactor: Lint project~~ refactor: Add linting to repository Jun 18, 2023

cbaker6 added 2 commits June 18, 2023 17:10

Merge branch 'main' into lint

cb711af

Update ci.yml

9f42fc2

update semantic to latest versions

7a4bb5f

remove babel folder from .gitignore

99bd48a

cbaker6 mentioned this pull request Jun 19, 2023

semantic-release 21.0.1 not compatible with current packages #45

Closed

4 tasks

mtrezza reviewed Jun 19, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

cbaker6 added 15 commits June 19, 2023 21:39

temp change to config

bedb96f

revert

8440606

Merge branch 'main' into lint

e2de28e

update package lock file

f29d8f6

nit

efe0774

Update ci.yml

6cde934

revert semantic to server versions

dc667eb

Merge branch 'lint' of https://github.com/cbaker6/parse-server-fs-ada…

232eaf4

…pter into lint

Update ci.yml

945746b

Update ci.yml

e64c635

fix package lock file

ceaff76

remove eslint

39eecef

Update ci.yml

ac2daa8

remove linter

ba220d0

finish removing lint

20bfbab

cbaker6 changed the title ~~ci: Add linting to repository~~ ci: Lint project and test node 19 Jan 22, 2024

cbaker6 added 3 commits January 21, 2024 19:48

remove spec lint

96d4c58

fix tests

6175463

fix tests

eb5670b

remove node 19 test

01c7283

cbaker6 changed the title ~~ci: Lint project and test node 19~~ refactor: Lint project and remove deprecated code Jan 22, 2024

mtrezza approved these changes Feb 15, 2024

View reviewed changes

mtrezza merged commit 903a72d into parse-community:main Feb 15, 2024
7 checks passed

cbaker6 deleted the lint branch February 15, 2024 14:21

parseplatformorg added the state:released label Feb 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Lint project and remove deprecated code #43

refactor: Lint project and remove deprecated code #43

cbaker6 commented Jun 18, 2023 •

edited

Loading

parse-github-assistant bot commented Jun 18, 2023 •

edited

Loading

codecov bot commented Jun 18, 2023 •

edited

Loading

cbaker6 commented Jun 18, 2023 •

edited

Loading

mtrezza commented Jun 18, 2023 •

edited

Loading

cbaker6 commented Jun 18, 2023 •

edited

Loading

mtrezza commented Jun 18, 2023 •

edited

Loading

cbaker6 commented Jun 18, 2023

mtrezza commented Jun 18, 2023 •

edited

Loading

cbaker6 commented Jun 18, 2023 •

edited

Loading

cbaker6 commented Jun 18, 2023

cbaker6 commented Jan 22, 2024 •

edited

Loading

parseplatformorg commented Feb 18, 2024

refactor: Lint project and remove deprecated code #43

refactor: Lint project and remove deprecated code #43

Conversation

cbaker6 commented Jun 18, 2023 • edited Loading

Pull Request

Issue

Approach

Tasks

parse-github-assistant bot commented Jun 18, 2023 • edited Loading

Thanks for opening this pull request!

codecov bot commented Jun 18, 2023 • edited Loading

Codecov Report

cbaker6 commented Jun 18, 2023 • edited Loading

mtrezza commented Jun 18, 2023 • edited Loading

cbaker6 commented Jun 18, 2023 • edited Loading

mtrezza commented Jun 18, 2023 • edited Loading

cbaker6 commented Jun 18, 2023

mtrezza commented Jun 18, 2023 • edited Loading

cbaker6 commented Jun 18, 2023 • edited Loading

cbaker6 commented Jun 18, 2023

cbaker6 commented Jan 22, 2024 • edited Loading

parseplatformorg commented Feb 18, 2024

cbaker6 commented Jun 18, 2023 •

edited

Loading

parse-github-assistant bot commented Jun 18, 2023 •

edited

Loading

codecov bot commented Jun 18, 2023 •

edited

Loading

cbaker6 commented Jun 18, 2023 •

edited

Loading

mtrezza commented Jun 18, 2023 •

edited

Loading

cbaker6 commented Jun 18, 2023 •

edited

Loading

mtrezza commented Jun 18, 2023 •

edited

Loading

mtrezza commented Jun 18, 2023 •

edited

Loading

cbaker6 commented Jun 18, 2023 •

edited

Loading

cbaker6 commented Jan 22, 2024 •

edited

Loading