Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Connection failure in Parse.Object.saveEventually and Parse.Object.destroyEventually not handled on custom Parse.Error.CONNECTION_FAILURE message #2032

Merged
merged 3 commits into from
Oct 4, 2023
Merged

fix: Connection failure in Parse.Object.saveEventually and Parse.Object.destroyEventually not handled on custom Parse.Error.CONNECTION_FAILURE message #2032

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
003837b
fix: Properly handle connection failure in `saveEventually` and `dest…
dplewis Sep 28, 2023
45ee633
Merge branch 'alpha' into eventually-connection
mtrezza Oct 3, 2023
6e95f04
Merge branch 'alpha' into eventually-connection
mtrezza Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ParseObject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1219,7 +1219,7 @@ class ParseObject {
try {
await this.save(null, options);
} catch (e) {
if (e.message === 'XMLHttpRequest failed: "Unable to connect to the Parse API"') {
if (e.code === ParseError.CONNECTION_FAILED) {
await EventuallyQueue.save(this, options);
EventuallyQueue.poll();
}
Expand Down Expand Up @@ -1363,7 +1363,7 @@ class ParseObject {
try {
await this.destroy(options);
} catch (e) {
if (e.message === 'XMLHttpRequest failed: "Unable to connect to the Parse API"') {
if (e.code === ParseError.CONNECTION_FAILED) {
await EventuallyQueue.destroy(this, options);
EventuallyQueue.poll();
}
Expand Down