Remove caching of auto-converted values #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #282 |
| || value instanceof ParseACL | ||
| || value instanceof ParseFile | ||
| || value instanceof ParseGeoPoint | ||
| || value instanceof ParseRelation; |
There was a problem hiding this comment.
Other than re-formatting, I've removed JSONObject and JSONArray
|
By analyzing the blame information on this pull request, we identified @grantland and @wangmengyan95 to be potential reviewers. |
|
Lovely! |
grantland
force-pushed
the
grantland.cached
branch
from
7c4f2b3 to
c02509a
Compare
|
Split into two PRs. Combining and unnecessary back and forth conversions moved to #305 |
|
I think this is included in #305. LGTM anyway. |
We cache auto-convert JSONObject/JSONArray values from Map/List which causes confusion when the cached value gets returned instead of fresh values from the server. This PR removes cache and instead auto-converts JSONObject/JSONArray values from Map/List on every call to getJSONObject(key) and getJSONArray(key).
grantland
force-pushed
the
grantland.cached
branch
from
c02509a to
34c5def
Compare
grantland
added a commit
that referenced
this pull request
Dec 17, 2015
Remove caching of auto-converted values
|
@grantland updated the pull request. |
|
@grantland updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cache auto-convert
JSONObject/JSONArrayvalues fromMap/Listwhich causes confusion when the cached value gets returned instead of fresh values from the server. This PR removes this cache and instead auto-convertsJSONObject/JSONArrayvalues fromMap/Liston every call togetJSONObject(key)andgetJSONArray(key).