Add null checking for push raw data #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @grantland to be a potential reviewer. |
|
nice one |
wangmengyan95
added a commit
that referenced
this pull request
Nov 23, 2015
…ing_for_push_raw_data Add null checking for push raw data
wangmengyan95
deleted the
wangmengyan.add_null_checking_for_push_raw_data
branch
| @@ -136,9 +136,15 @@ public void onReceive(Context context, Intent intent) { | |||
| * An {@code Intent} containing the channel and data of the current push notification. | |||
| */ | |||
| protected void onPushReceive(Context context, Intent intent) { | |||
| String pushDataStr = intent.getStringExtra(KEY_PUSH_DATA); | |||
| if (pushDataStr == null) { | |||
| PLog.e(TAG, "Can not get push data from intent."); | |||
There was a problem hiding this comment.
s/Can not get/Unable to read/g
|
@wangmengyan95 updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#260, we get some exceptions from developers about getting null push raw data. Not sure why this happen but it make sense to add some null checking.