-
-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update all dependencies and modernize the source base #1095
Conversation
- Replace all anonymous classes with lambdas where possible. - Make all fields final where possible - Internal classes as static where possible - Replace test assertions with context ones - Use diamond <> where possible - Use method references where possible - Imports re-arrange
Hello @Jawnnypoo @mtrezza I finally dared to submit my first PR here. Not sure if you are the right persons to ping, but I saw you're more likely active here. Don't be afraid of the huge changes, most of them are just replacing callbacks with lambdas and just syntax sugaring around Java 8. I will be very happy if you have time to check this PR. |
Thanks for the work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is a huge PR! Thanks for all the effort, I have not had time to be active with this project, but it looks good from my perspective!
@L3K0V Looks like there is a compilation issue:
|
@Jawnnypoo any ideas what can cause this? On this line there's nothing interesting.... |
Hmm yeah I am not really sure. Maybe you can remove this check. |
Fun fact is that locally I'm able to run the same Gradle script as the GitHub CI and it's working. |
Specify kotlin and java compatibility versions all over the place
Codecov Report
@@ Coverage Diff @@
## master #1095 +/- ##
=========================================
Coverage ? 65.06%
Complexity ? 2208
=========================================
Files ? 122
Lines ? 9463
Branches ? 1317
=========================================
Hits ? 6157
Misses ? 2799
Partials ? 507
Continue to review full report at Codecov.
|
Set minimum coverage of 65% instead of 45%
Remove explicit chartsets and locales because requires newer SDK version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! This is truly a mammoth PR, and a milestone for the Parse Android SDK!
# [2.0.0](1.22.0...2.0.0) (2021-10-10) ### Bug Fixes * remove GCM module ([parse-community#1091](https://github.com/mtrezza/Parse-SDK-Android/issues/1091)) ([aa16bcf](aa16bcf)) * upgrade Facebook SDK ([parse-community#1105](https://github.com/mtrezza/Parse-SDK-Android/issues/1105)) ([6f4bdb0](6f4bdb0)) ### Features * update all dependencies and modernize the source base ([parse-community#1095](https://github.com/mtrezza/Parse-SDK-Android/issues/1095)) ([a977d11](a977d11)) ### BREAKING CHANGES * CHANGE Support for Google Cloud Messaging (GCM) is removed, use Firebase Cloud Messaging instead. See the [Google developer documentation](https://developers.google.com/cloud-messaging/faq) for more details and migration assistance. ([aa16bcf](aa16bcf))
@@ -45,10 +34,6 @@ artifacts { | |||
|
|||
apply plugin: 'jacoco' | |||
|
|||
jacoco { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removal of this? Other files still have this block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Feel free to add it to your #1122
This is first of many PRs which I want to introduce in order to get this SDK up to date.
First step in my master plan is update all dependencies, Gradle version and used plugins. Also this PR will cover updating to Java 8 and taking advantage of all sweet features of it. I prefer to make a small incremental steps so the PRs to be easy to review.
Code optimisation which have been done:
NOTE: No business logic was changed so far
Updating of the Firebase Messaging should address #1071 (comment) as there introduce some breaking changes and when using the Parse FCM there are signature issues with latest version of FCM