The design of .Retry() is wrong

[beef9999]

        for {
		resp, body, errs = s.getResponseBytes()
		if errs != nil {
			return nil, nil, errs
		}
		if s.isRetryableRequest(resp) {
			resp.Header.Set("Retry-Count", strconv.Itoa(s.Retryable.Attempt))
			break
		}
	}

The current .Retry() mechanism only works when server successfully responds with a specific set of http codes. But in other scenarios, http requests might fail because of network connectivity problem, insufficient OS resource, etc, which will only exit at the first return(see above) , without proper retries.

[zuoRambo]

Agree with you! When the error returned by client.Do is not nil, we should retry.

[jayi]

+1

[edshv]

+1

[edshv]

Also, any retry logic specified in Client/transport is overwritten