Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add/Remove invlunerables #113

Merged
merged 3 commits into from
Nov 7, 2023
Merged

[Feature] Add/Remove invlunerables #113

merged 3 commits into from
Nov 7, 2023

Conversation

lazam
Copy link
Contributor

@lazam lazam commented Nov 2, 2023

Resolves: #88

  • Added two new endpoint to add and remove invulnerables via {add, remove}_invulnerable pallet
  • Retain the set_invulnerable endpoint to behave as set_invulnerable pallet

@lazam lazam requested a review from PierreBesson as a code owner November 2, 2023 19:43
BulatSaif
BulatSaif requested changes Nov 3, 2023
View reviewed changes
app/lib/network_utils.py Outdated Show resolved Hide resolved
PierreBesson
PierreBesson suggested changes Nov 3, 2023
View reviewed changes
app/routers/apis.py Show resolved Hide resolved
@lazam lazam merged commit 21ef6a9 into main Nov 7, 2023
3 checks passed
@lazam lazam deleted the al-88-add-remove-invulnerables branch November 7, 2023 12:04
@nielzon-t
Copy link

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BulatSaif BulatSaif BulatSaif approved these changes

@PierreBesson PierreBesson PierreBesson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace usage of set_invulnerable by add_invulnerable and remove_invulnerable
4 participants
@lazam @nielzon-t @PierreBesson @BulatSaif