Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove TaskManagerBuilder #5725

Merged
merged 4 commits into from
Apr 21, 2020
Merged

Remove TaskManagerBuilder #5725

merged 4 commits into from
Apr 21, 2020

Conversation

pscott
Copy link
Contributor

@pscott pscott commented Apr 21, 2020

This PR aims to address this comment by removing the channel from TaskManager.

If we wish to remove the channel from TaskManager, we need to:

  • Remove the send field in the SpawnTaskHandle, replacing it with the executor
  • Remove the TaskManagerBuilder, and only spawn tasks once the TaskManager has already been built
  • Build the TaskManager earlier in the service builder, so that we can spawn tasks appropriately.

@pscott pscott added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes labels Apr 21, 2020
@pscott pscott self-assigned this Apr 21, 2020
@parity-cla-bot
Copy link

It looks like @pscott signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@pscott pscott mentioned this pull request Apr 21, 2020
Merged
1 task
tomaka
tomaka approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@tomaka tomaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

client/service/src/lib.rs Outdated Show resolved Hide resolved
@tomaka
Copy link
Contributor

tomaka commented Apr 21, 2020

Is there a reason for this to be a draft and "in progress"?

@pscott
Copy link
Contributor Author

pscott commented Apr 21, 2020 •
edited
Loading

Is there a reason for this to be a draft and "in progress"?

Because tests are failing... mainly version_is_full() but I have no idea why and I don't think it's linked to this PR (it's also failing on master).

I usually try to make sure tests pass before I switch to "non-draft" :)

@tomaka
Copy link
Contributor

tomaka commented Apr 21, 2020

If it's also failing on master, then yeah it shouldn't block this PR, especially if the CI passes.

@pscott pscott marked this pull request as ready for review April 21, 2020 16:53
Scott Piriou added 2 commits April 21, 2020 19:45
Merge branch 'master' of github.com:paritytech/substrate into scott_r…
616c2f2 
…emove_channel_from_task_manager
Merge branch 'scott_remove_channel_from_task_manager' of github.com:p…
9a10a1b 
…aritytech/substrate into scott_remove_channel_from_task_manager
@bkchr bkchr merged commit 761d3c8 into master Apr 21, 2020
@bkchr bkchr deleted the scott_remove_channel_from_task_manager branch April 21, 2020 22:35
@gavofyork gavofyork mentioned this pull request May 22, 2020
Closed
24 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NikVolf NikVolf NikVolf approved these changes

@tomaka tomaka tomaka approved these changes

Assignees

@pscott pscott

Labels
A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pscott @parity-cla-bot @tomaka @NikVolf @bkchr