Make sure we poll authority event stream until all events are processed #5608

bkchr · 2020-04-11T18:04:59Z

No description provided.

mxinden

Thanks a bunch for catching this!

I will follow up on this next week, removing the mix of Poll and try operator to make returns easier to review.

Fixing authority discovery leak.

bkchr added 2 commits April 11, 2020 17:56

Make sure we poll authority event stream until all events are processed

772ec10

Add test

dba3d37

bkchr added A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes labels Apr 11, 2020

bkchr requested a review from mxinden as a code owner April 11, 2020 18:04

mxinden approved these changes Apr 11, 2020

View reviewed changes

bkchr merged commit 4af60fd into master Apr 11, 2020

bkchr deleted the bkchr-fix-authority-discovery branch April 11, 2020 20:12

mxinden added a commit to paritytech/polkadot that referenced this pull request Apr 11, 2020

*: Include paritytech/substrate#5608

6a482e7

Fixing authority discovery leak.

mxinden mentioned this pull request Apr 14, 2020

client/authority-discovery: Rework error handling #5631

Merged

gavofyork mentioned this pull request Apr 15, 2020

Prepare for Polkadot launch and Substrate 2.0 freeze #4961

Closed

24 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make sure we poll authority event stream until all events are processed #5608

Make sure we poll authority event stream until all events are processed #5608

bkchr commented Apr 11, 2020

mxinden left a comment

Make sure we poll authority event stream until all events are processed #5608

Make sure we poll authority event stream until all events are processed #5608

Conversation

bkchr commented Apr 11, 2020

mxinden left a comment

Choose a reason for hiding this comment