This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Regression algorithm for runtime benchmarks #5288
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcio-diaz
added
the
A3-in_progress
Pull request is in progress. No review needed at this stage.
label
Mar 18, 2020
24 tasks
Have you tested this with some real benchmarks? Can you post the full results here? |
gavofyork
added
A8-mergeoncegreen
and removed
A3-in_progress
Pull request is in progress. No review needed at this stage.
labels
Mar 23, 2020
gavofyork
approved these changes
Mar 23, 2020
bkchr
pushed a commit
that referenced
this pull request
Mar 24, 2020
* Add linregress * Regression, initial stuff. * More analytics * whitespace * Fix * Median slopes regression algo * Warnings * Update to lastest benchmark changes. * Use both algorithms temp. * Move analysis to frame. * Fix tests. * Only build analysis in std Co-authored-by: Gav Wood <[email protected]>
rakanalh
pushed a commit
to rakanalh/substrate
that referenced
this pull request
Mar 25, 2020
* Add linregress * Regression, initial stuff. * More analytics * whitespace * Fix * Median slopes regression algo * Warnings * Update to lastest benchmark changes. * Use both algorithms temp. * Move analysis to frame. * Fix tests. * Only build analysis in std Co-authored-by: Gav Wood <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(In progress)
I think the code of Gav is good, so I'll just add tests/graphs to compare both algorithms and do some cleaning.
Also, we need to see the best output for the scripts that will run it.